Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1992103002: Delay button bounds offset calculation until window is actually visible (Closed)

Created:
4 years, 7 months ago by kylix_rd
Modified:
4 years, 7 months ago
Reviewers:
Ilya Kulshin, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delay button bounds offset calculation until window is actually visible BUG=609398 Committed: https://crrev.com/b25c378008aadbfb82c0066601372add9475b7af Cr-Commit-Position: refs/heads/master@{#394806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/frame/minimize_button_metrics_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
kylix_rd
This is a minor tweak to the whole identity switcher button positioning issue. When the ...
4 years, 7 months ago (2016-05-18 22:57:04 UTC) #3
Ilya Kulshin
lgtm
4 years, 7 months ago (2016-05-19 00:34:18 UTC) #4
sky
LGTM
4 years, 7 months ago (2016-05-19 15:45:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992103002/1
4 years, 7 months ago (2016-05-19 15:50:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 17:35:10 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 17:36:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b25c378008aadbfb82c0066601372add9475b7af
Cr-Commit-Position: refs/heads/master@{#394806}

Powered by Google App Engine
This is Rietveld 408576698