Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: src/heap/objects-visiting-inl.h

Issue 1992093003: [heap] don't flush async functions, they may be resumed later (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: [heap] don't flush async functions, they may be resumed later Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/harmony/async-function-stacktrace.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/objects-visiting-inl.h
diff --git a/src/heap/objects-visiting-inl.h b/src/heap/objects-visiting-inl.h
index 4373451e44f45aa86ab14aa7e922974370216b3c..01dd3797753076ab400d504afcfb18c792356315 100644
--- a/src/heap/objects-visiting-inl.h
+++ b/src/heap/objects-visiting-inl.h
@@ -647,9 +647,10 @@ bool StaticMarkingVisitor<StaticVisitor>::IsFlushable(
return false;
}
- // We do not (yet?) flush code for generator functions, because we don't know
- // if there are still live activations (generator objects) on the heap.
- if (shared_info->is_generator()) {
+ // We do not (yet?) flush code for generator functions, or async functions,
Hannes Payer (out of office) 2016/05/20 07:13:52 How about a list of items enumerating what we don'
caitp (gmail) 2016/05/20 07:55:48 isn't that what this routine is? thats how it look
Hannes Payer (out of office) 2016/05/20 12:00:41 Ah, async is based on generators. Then the comment
+ // because we don't know if there are still live activations
+ // (generator objects) on the heap.
+ if (shared_info->is_resumable()) {
return false;
}
« no previous file with comments | « no previous file | test/mjsunit/harmony/async-function-stacktrace.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698