[Devtools] Fixed regression with negative filters in networking

[Devtools] Fixed regression with negative filters in networking

Fixed regression bug where if you negative filtered in network panel
it would not work properly.

BUG=611428, 576022
R=lushnikov

Committed: https://crrev.com/f3bce856f7bf088ad07fdab4abe7fbf7d3124742
Cr-Commit-Position: refs/heads/master@{#395220}

[allada, 2016-05-18 22:52:26]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[allada, 2016-05-18 22:53:04]

PTL

[commit-bot: I haz the power, 2016-05-18 22:53:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1992093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1992093002/1

[commit-bot: I haz the power, 2016-05-19 00:45:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 00:45:07]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-05-20 21:20:30]

lgtm

https://codereview.chromium.org/1992093002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html
(right):

https://codereview.chromium.org/1992093002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html:59:
WebInspector.panels.network._networkLogView._textFilterUI._filterInputElement.value
= filterObj.filterText;
let's put the logic which heavily accesses private fields into a utility method
with a fine name - this way it would be easier to re-factor the code in future.

https://codereview.chromium.org/1992093002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html:80:
<p>Tests fetch network resource type and content.</p>
Text seems to be outdated

[allada, 2016-05-20 23:10:47]

https://codereview.chromium.org/1992093002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html
(right):

https://codereview.chromium.org/1992093002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html:59:
WebInspector.panels.network._networkLogView._textFilterUI._filterInputElement.value
= filterObj.filterText;
On 2016/05/20 21:20:30, lushnikov wrote:
> let's put the logic which heavily accesses private fields into a utility
method
> with a fine name - this way it would be easier to re-factor the code in
future.

Done.

https://codereview.chromium.org/1992093002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html:80:
<p>Tests fetch network resource type and content.</p>
On 2016/05/20 21:20:30, lushnikov wrote:
> Text seems to be outdated

Done.

[allada, 2016-05-20 23:10:56]

The CQ bit was checked by allada@chromium.org

[allada, 2016-05-20 23:10:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/1992093002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-20 23:11:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1992093002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1992093002/40001

[commit-bot: I haz the power, 2016-05-21 00:43:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-21 00:45:12]

Description was changed from

==========
[Devtools] Fixed regression with negative filters in networking

Fixed regression bug where if you negative filtered in network panel
it would not work properly.

BUG=611428,576022
R=lushnikov
==========

to

==========
[Devtools] Fixed regression with negative filters in networking

Fixed regression bug where if you negative filtered in network panel
it would not work properly.

BUG=611428,576022
R=lushnikov

Committed: https://crrev.com/f3bce856f7bf088ad07fdab4abe7fbf7d3124742
Cr-Commit-Position: refs/heads/master@{#395220}
==========

[commit-bot: I haz the power, 2016-05-21 00:45:13]

Patchset 3 (id:??) landed as
https://crrev.com/f3bce856f7bf088ad07fdab4abe7fbf7d3124742
Cr-Commit-Position: refs/heads/master@{#395220}