Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1992083005: Removed unnecessary dependency on data_pipe_utils (Closed)

Created:
4 years, 7 months ago by Sean Klein
Modified:
4 years, 7 months ago
Reviewers:
dalesat, johngro
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Removed unnecessary dependency on data_pipe_utils Removing this dependency will make extracting Motown from the Mojo codebase significantly easier. BUG=None R=johngro@google.com Committed: https://chromium.googlesource.com/external/mojo/+/db510758fc51109b62a5eb3bde943991b5bc7ac0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M services/media/factory_service/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Sean Klein
4 years, 7 months ago (2016-05-19 23:31:28 UTC) #2
johngro
LGTM That said, this is Dale's code, so you might want to wait for his ...
4 years, 7 months ago (2016-05-21 00:35:11 UTC) #6
Sean Klein
Committed patchset #1 (id:1) manually as db510758fc51109b62a5eb3bde943991b5bc7ac0 (presubmit successful).
4 years, 7 months ago (2016-05-23 22:44:00 UTC) #8
dalesat
4 years, 7 months ago (2016-05-23 23:05:10 UTC) #9
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698