Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1992083003: gn: Explicitly pass rtti compiler flag (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, vogelheim, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Explicitly pass rtti compiler flag GCC doesn't turn on rtti by default, while clang does. Setting it explicitly to make sure we always compile as desired. BUG=chromium:474921 Committed: https://crrev.com/819abfc903928d84bebbef58fe53ca86843d4531 Cr-Commit-Position: refs/heads/master@{#394819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992083003/1
4 years, 7 months ago (2016-05-19 09:49:12 UTC) #2
Michael Achenbach
PTAL. Spotted this while diffing gyp/gn stuff. ICU sets this explicitly in gyp: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/icu/icu.gyp&l=216
4 years, 7 months ago (2016-05-19 10:17:10 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 10:46:20 UTC) #8
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-19 18:27:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992083003/1
4 years, 7 months ago (2016-05-19 18:29:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 18:34:01 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 18:36:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/819abfc903928d84bebbef58fe53ca86843d4531
Cr-Commit-Position: refs/heads/master@{#394819}

Powered by Google App Engine
This is Rietveld 408576698