Assert complex precondition in SkGlyphCache::Visit.

Assert complex precondition in SkGlyphCache::Visit.

SkGlyphCache::Visit takes a descriptor and a typeface, but it is implied
that the fFontID in the descriptor is the id of the typeface. This seems
to be handled correctly by current callers but this is a subtle
requirement which if violated could lead to subtle bugs.

Committed: https://skia.googlesource.com/skia/+/de3c3568ee5137fa8752491362893ae1d701d709

[bungeman-skia, 2016-05-18 21:32:32]

Description was changed from

==========
Assert complex precondition in SkGlyphCache::Visit.

SkGlyphCache::Visit takes a descriptor and a typeface, but it is implied
that the fFontID in the descriptor is the id of the typeface. This seems
to be handled correctly by current callers but as this is a subtle
requirement which if violated could lead to subtle bugs.
==========

to

==========
Assert complex precondition in SkGlyphCache::Visit.

SkGlyphCache::Visit takes a descriptor and a typeface, but it is implied
that the fFontID in the descriptor is the id of the typeface. This seems
to be handled correctly by current callers but as this is a subtle
requirement which if violated could lead to subtle bugs.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-05-18 21:32:54]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-18 21:32:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1992053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1992053002/1

[bungeman-skia, 2016-05-18 21:33:03]

Description was changed from

==========
Assert complex precondition in SkGlyphCache::Visit.

SkGlyphCache::Visit takes a descriptor and a typeface, but it is implied
that the fFontID in the descriptor is the id of the typeface. This seems
to be handled correctly by current callers but as this is a subtle
requirement which if violated could lead to subtle bugs.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Assert complex precondition in SkGlyphCache::Visit.

SkGlyphCache::Visit takes a descriptor and a typeface, but it is implied
that the fFontID in the descriptor is the id of the typeface. This seems
to be handled correctly by current callers but as this is a subtle
requirement which if violated could lead to subtle bugs.
==========

[bungeman-skia, 2016-05-18 21:33:23]

Description was changed from

==========
Assert complex precondition in SkGlyphCache::Visit.

SkGlyphCache::Visit takes a descriptor and a typeface, but it is implied
that the fFontID in the descriptor is the id of the typeface. This seems
to be handled correctly by current callers but as this is a subtle
requirement which if violated could lead to subtle bugs.
==========

to

==========
Assert complex precondition in SkGlyphCache::Visit.

SkGlyphCache::Visit takes a descriptor and a typeface, but it is implied
that the fFontID in the descriptor is the id of the typeface. This seems
to be handled correctly by current callers but this is a subtle
requirement which if violated could lead to subtle bugs.
==========

[bungeman-skia, 2016-05-18 21:33:41]

bungeman@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[commit-bot: I haz the power, 2016-05-18 21:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 21:51:28]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-05-18 22:48:35]

lgtm

[bungeman-skia, 2016-05-19 14:42:49]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-05-19 14:42:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1992053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1992053002/1

[commit-bot: I haz the power, 2016-05-19 14:43:56]

Description was changed from

==========
Assert complex precondition in SkGlyphCache::Visit.

SkGlyphCache::Visit takes a descriptor and a typeface, but it is implied
that the fFontID in the descriptor is the id of the typeface. This seems
to be handled correctly by current callers but this is a subtle
requirement which if violated could lead to subtle bugs.
==========

to

==========
Assert complex precondition in SkGlyphCache::Visit.

SkGlyphCache::Visit takes a descriptor and a typeface, but it is implied
that the fFontID in the descriptor is the id of the typeface. This seems
to be handled correctly by current callers but this is a subtle
requirement which if violated could lead to subtle bugs.

Committed:
https://skia.googlesource.com/skia/+/de3c3568ee5137fa8752491362893ae1d701d709
==========

[commit-bot: I haz the power, 2016-05-19 14:43:57]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/de3c3568ee5137fa8752491362893ae1d701d709