Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1992023003: Correctly check for overflow in FX_atonum. (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Correctly check for overflow in FX_atonum. Instead of the existing method, use the CheckedNumeric class to check for overflow during conversion. BUG=chromium:596526 Committed: https://pdfium.googlesource.com/pdfium/+/bc8a64029f898286c3dcad3a6cecdc98ef30b139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M core/fxcrt/fx_basic_util.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 7 months ago (2016-05-19 18:22:49 UTC) #2
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-19 18:34:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992023003/1
4 years, 7 months ago (2016-05-19 18:35:16 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 18:37:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/bc8a64029f898286c3dcad3a6cecdc98ef30...

Powered by Google App Engine
This is Rietveld 408576698