Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1992013003:
Adding another test expectations for Android. (Closed)
|
Created:
4 years, 7 months ago by cblume Modified:
4 years, 7 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdding another test expectations for Android.
Nexus 6:
WebglConformance.conformance_glsl_misc_shader_with_256_character_identifier_frag
BUG=611945
R=kbr@chromium.org
Committed: https://crrev.com/757fd476b360a563bcc468b05aff7816c5fb6e4b
Cr-Commit-Position: refs/heads/master@{#394665}
Patch Set 1 #Patch Set 2 : Rebasing #Patch Set 3 : Trying to rebase again? #Messages
Total messages: 16 (8 generated)
Description was changed from ========== Adding another test expectations for Android. Nexus 6: WebglConformance.conformance_glsl_misc_shader_with_256_character_identifier_frag BUG=611945 R=kbr@chromium.org Adding a few more test expectations for Android. Nexus 5X: WebglConformance.conformance_textures_image_bitmap_from_image_bitmap_tex_2d_rgba_rgba_unsigned_short_5_5_5_1 WebglConformance.conformance_uniforms_uniform_samplers_test WebglConformance.deqp_data_gles2_shaders_preprocessor Nexus 6: WebglConformance.conformance_glsl_misc_shader_with_256_character_define BUG=611945, 610951 R=kbr@chromium.org ========== to ========== Adding another test expectations for Android. Nexus 6: WebglConformance.conformance_glsl_misc_shader_with_256_character_identifier_frag BUG=611945 R=kbr@chromium.org Adding a few more test expectations for Android. Nexus 5X: WebglConformance.conformance_textures_image_bitmap_from_image_bitmap_tex_2d_rgba_rgba_unsigned_short_5_5_5_1 WebglConformance.conformance_uniforms_uniform_samplers_test WebglConformance.deqp_data_gles2_shaders_preprocessor Nexus 6: WebglConformance.conformance_glsl_misc_shader_with_256_character_define BUG=611945, 610951 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
PTAL
lgtm
The CQ bit was checked by cblume@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992013003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...) android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_optional_gpu_tests_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...) ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...) win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...) win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
Patch collision? Also, the CL description looks weird, like two were concatenated together.
Description was changed from ========== Adding another test expectations for Android. Nexus 6: WebglConformance.conformance_glsl_misc_shader_with_256_character_identifier_frag BUG=611945 R=kbr@chromium.org Adding a few more test expectations for Android. Nexus 5X: WebglConformance.conformance_textures_image_bitmap_from_image_bitmap_tex_2d_rgba_rgba_unsigned_short_5_5_5_1 WebglConformance.conformance_uniforms_uniform_samplers_test WebglConformance.deqp_data_gles2_shaders_preprocessor Nexus 6: WebglConformance.conformance_glsl_misc_shader_with_256_character_define BUG=611945, 610951 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Adding another test expectations for Android. Nexus 6: WebglConformance.conformance_glsl_misc_shader_with_256_character_identifier_frag BUG=611945 R=kbr@chromium.org ==========
The CQ bit was checked by cblume@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/1992013003/#ps40001 (title: "Trying to rebase again?")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992013003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992013003/40001
Message was sent while issue was closed.
Description was changed from ========== Adding another test expectations for Android. Nexus 6: WebglConformance.conformance_glsl_misc_shader_with_256_character_identifier_frag BUG=611945 R=kbr@chromium.org ========== to ========== Adding another test expectations for Android. Nexus 6: WebglConformance.conformance_glsl_misc_shader_with_256_character_identifier_frag BUG=611945 R=kbr@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Adding another test expectations for Android. Nexus 6: WebglConformance.conformance_glsl_misc_shader_with_256_character_identifier_frag BUG=611945 R=kbr@chromium.org ========== to ========== Adding another test expectations for Android. Nexus 6: WebglConformance.conformance_glsl_misc_shader_with_256_character_identifier_frag BUG=611945 R=kbr@chromium.org Committed: https://crrev.com/757fd476b360a563bcc468b05aff7816c5fb6e4b Cr-Commit-Position: refs/heads/master@{#394665} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/757fd476b360a563bcc468b05aff7816c5fb6e4b Cr-Commit-Position: refs/heads/master@{#394665} |
