chrome/browser/ui/views/accelerator_table.cc - Issue 1992003002: Re-add backspace-goes-back as a default disabled finch trial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/accelerator_table.cc

Issue 1992003002: Re-add backspace-goes-back as a default disabled finch trial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address revieww comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | chrome/browser/ui/views/constrained_window_views_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/accelerator_table.cc

diff --git a/chrome/browser/ui/views/accelerator_table.cc b/chrome/browser/ui/views/accelerator_table.cc

index 8cc7dc486dc52fa873584bdaf5c91d49a7b0ba70..d1a069f68382935906782042104dc3d7c7059c10 100644

--- a/chrome/browser/ui/views/accelerator_table.cc

+++ b/chrome/browser/ui/views/accelerator_table.cc

@@ -35,6 +35,7 @@ const ui::EventFlags kPlatformModifier = ui::EF_CONTROL_DOWN;

// http://blogs.msdn.com/b/oldnewthing/archive/2004/03/29/101121.aspx

const AcceleratorMapping kAcceleratorMap[] = {

{ ui::VKEY_LEFT, ui::EF_ALT_DOWN, IDC_BACK },

+ { ui::VKEY_BACK, ui::EF_NONE, IDC_BACKSPACE_BACK },

{ ui::VKEY_D, ui::EF_CONTROL_DOWN, IDC_BOOKMARK_PAGE },

{ ui::VKEY_D, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,

IDC_BOOKMARK_ALL_TABS },

@@ -51,6 +52,7 @@ const AcceleratorMapping kAcceleratorMap[] = {

{ ui::VKEY_B, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN, IDC_FOCUS_BOOKMARKS },

{ ui::VKEY_A, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN, IDC_FOCUS_INFOBARS },

{ ui::VKEY_RIGHT, ui::EF_ALT_DOWN, IDC_FORWARD },

+ { ui::VKEY_BACK, ui::EF_SHIFT_DOWN, IDC_BACKSPACE_FORWARD },

{ ui::VKEY_I, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN, IDC_DEV_TOOLS },

{ ui::VKEY_F12, ui::EF_NONE, IDC_DEV_TOOLS_TOGGLE },

{ ui::VKEY_J, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN,

« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | chrome/browser/ui/views/constrained_window_views_browsertest.cc » ('j') | no next file with comments »