chrome/browser/ui/views/frame/browser_view.cc - Issue 1992003002: Re-add backspace-goes-back as a default disabled finch trial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1992003002: Re-add backspace-goes-back as a default disabled finch trial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix assert in test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/constrained_window_views_browsertest.cc ('K') | « chrome/browser/ui/views/constrained_window_views_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index ed2a15b0a540184875beb7d65bec8ef929c11ae2..9dcb998a266e9bb551fb67aa388362427b59198a 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -2432,13 +2432,17 @@ void BrowserView::UpdateAcceleratorMetrics(const ui::Accelerator& accelerator,

// on Chrome OS.

switch (command_id) {

case IDC_BACK:

- if (key_code == ui::VKEY_BROWSER_BACK)

+ if (key_code == ui::VKEY_BACK)

+ content::RecordAction(UserMetricsAction("Accel_Back_Backspace"));

Peter Kasting 2016/05/19 09:28:30 Will this and the bit below even be reached? Won'

ojan 2016/05/20 16:33:48 Ugh. Yeah. This just just from starting with a rev

+ else if (key_code == ui::VKEY_BROWSER_BACK)

content::RecordAction(UserMetricsAction("Accel_Back_F1"));

else if (key_code == ui::VKEY_LEFT)

content::RecordAction(UserMetricsAction("Accel_Back_Left"));

break;

case IDC_FORWARD:

- if (key_code == ui::VKEY_BROWSER_FORWARD)

+ if (key_code == ui::VKEY_BACK)

+ content::RecordAction(UserMetricsAction("Accel_Forward_Backspace"));

+ else if (key_code == ui::VKEY_BROWSER_FORWARD)

content::RecordAction(UserMetricsAction("Accel_Forward_F2"));

else if (key_code == ui::VKEY_RIGHT)

content::RecordAction(UserMetricsAction("Accel_Forward_Right"));

« chrome/browser/ui/views/constrained_window_views_browsertest.cc ('K') | « chrome/browser/ui/views/constrained_window_views_browsertest.cc ('k') | no next file » | no next file with comments »