chrome/browser/global_keyboard_shortcuts_mac.mm - Issue 1992003002: Re-add backspace-goes-back as a default disabled finch trial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/global_keyboard_shortcuts_mac.mm

Issue 1992003002: Re-add backspace-goes-back as a default disabled finch trial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix assert in test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/chrome_command_ids.h ('K') | « chrome/browser/app_mode/app_mode_utils.cc ('k') | chrome/browser/global_keyboard_shortcuts_mac_unittest.mm » ('j') | chrome/browser/ui/browser_command_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/global_keyboard_shortcuts_mac.mm

diff --git a/chrome/browser/global_keyboard_shortcuts_mac.mm b/chrome/browser/global_keyboard_shortcuts_mac.mm

index a0f05881379d114d40566956d44868b2ca17c8b9..d5ba13821419c8107394d0d16a21997616a2d4c5 100644

--- a/chrome/browser/global_keyboard_shortcuts_mac.mm

+++ b/chrome/browser/global_keyboard_shortcuts_mac.mm

@@ -103,6 +103,8 @@ const KeyboardShortcutData* GetBrowserKeyboardShortcutTable(

//--- ----- ----- ------

{true, false, false, false, kVK_LeftArrow, 0, IDC_BACK},

{true, false, false, false, kVK_RightArrow, 0, IDC_FORWARD},

+ {false, false, false, false, kVK_Delete, 0, IDC_BACKSPACE_BACK},

+ {false, true, false, false, kVK_Delete, 0, IDC_BACKSPACE_FORWARD},

{true, true, false, false, 0, 'c', IDC_DEV_TOOLS_INSPECT},

};