Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: chrome/browser/app_mode/app_mode_utils.cc

Issue 1992003002: Re-add backspace-goes-back as a default disabled finch trial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address revieww comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/chrome_command_ids.h ('k') | chrome/browser/global_keyboard_shortcuts_mac.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/app_mode/app_mode_utils.h" 5 #include "chrome/browser/app_mode/app_mode_utils.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "chrome/app/chrome_command_ids.h" 12 #include "chrome/app/chrome_command_ids.h"
13 #include "chrome/common/chrome_switches.h" 13 #include "chrome/common/chrome_switches.h"
14 14
15 namespace chrome { 15 namespace chrome {
16 16
17 bool IsCommandAllowedInAppMode(int command_id) { 17 bool IsCommandAllowedInAppMode(int command_id) {
18 DCHECK(IsRunningInForcedAppMode()); 18 DCHECK(IsRunningInForcedAppMode());
19 19
20 const int kAllowed[] = { 20 const int kAllowed[] = {
21 IDC_BACK, 21 IDC_BACK,
22 IDC_FORWARD, 22 IDC_FORWARD,
23 IDC_BACKSPACE_BACK,
24 IDC_BACKSPACE_FORWARD,
23 IDC_RELOAD, 25 IDC_RELOAD,
24 IDC_STOP, 26 IDC_STOP,
25 IDC_RELOAD_BYPASSING_CACHE, 27 IDC_RELOAD_BYPASSING_CACHE,
26 IDC_RELOAD_CLEARING_CACHE, 28 IDC_RELOAD_CLEARING_CACHE,
27 IDC_CUT, 29 IDC_CUT,
28 IDC_COPY, 30 IDC_COPY,
29 IDC_PASTE, 31 IDC_PASTE,
30 IDC_ZOOM_PLUS, 32 IDC_ZOOM_PLUS,
31 IDC_ZOOM_NORMAL, 33 IDC_ZOOM_NORMAL,
32 IDC_ZOOM_MINUS, 34 IDC_ZOOM_MINUS,
(...skipping 13 matching lines...) Expand all
46 IsRunningInForcedAppMode(); 48 IsRunningInForcedAppMode();
47 } 49 }
48 50
49 bool IsRunningInForcedAppMode() { 51 bool IsRunningInForcedAppMode() {
50 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); 52 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
51 return command_line->HasSwitch(switches::kForceAppMode) && 53 return command_line->HasSwitch(switches::kForceAppMode) &&
52 command_line->HasSwitch(switches::kAppId); 54 command_line->HasSwitch(switches::kAppId);
53 } 55 }
54 56
55 } // namespace chrome 57 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/app/chrome_command_ids.h ('k') | chrome/browser/global_keyboard_shortcuts_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698