chrome/app/chrome_command_ids.h - Issue 1992003002: Re-add backspace-goes-back as a default disabled finch trial

Side by Side Diff: chrome/app/chrome_command_ids.h

Issue 1992003002: Re-add backspace-goes-back as a default disabled finch trial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix assert in test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_APP_CHROME_COMMAND_IDS_H_	5 #ifndef CHROME_APP_CHROME_COMMAND_IDS_H_

6 #define CHROME_APP_CHROME_COMMAND_IDS_H_	6 #define CHROME_APP_CHROME_COMMAND_IDS_H_

7	7

8 // This file lists all the command IDs understood by e.g. the browser.	8 // This file lists all the command IDs understood by e.g. the browser.

9 // It is used by Windows RC files, Mac NIB files, and other platforms too.	9 // It is used by Windows RC files, Mac NIB files, and other platforms too.

10	10

(...skipping 15 matching lines...) Expand all Loading...
26 // TODO: Reorder to be in visible order; collapse holes	26 // TODO: Reorder to be in visible order; collapse holes

27 #define IDC_BACK 33000	27 #define IDC_BACK 33000

28 #define IDC_FORWARD 33001	28 #define IDC_FORWARD 33001

29 #define IDC_RELOAD 33002	29 #define IDC_RELOAD 33002

30 #define IDC_HOME 33003	30 #define IDC_HOME 33003

31 #define IDC_OPEN_CURRENT_URL 33004	31 #define IDC_OPEN_CURRENT_URL 33004

32 #define IDC_STOP 33006	32 #define IDC_STOP 33006

33 #define IDC_RELOAD_BYPASSING_CACHE 33007	33 #define IDC_RELOAD_BYPASSING_CACHE 33007

34 #define IDC_LOAD_NEW_TAB_PAGE 33008	34 #define IDC_LOAD_NEW_TAB_PAGE 33008

35 #define IDC_RELOAD_CLEARING_CACHE 33009	35 #define IDC_RELOAD_CLEARING_CACHE 33009

	36 #define IDC_BACKSPACE_BACK 33010
	Matt Giuca 2016/05/19 02:04:33 Do these need to be added to histograms.xml? Do these need to be added to histograms.xml? ojan 2016/05/20 16:33:48 We're not planning to measure anything here. So, I Show quoted text On 2016/05/19 at 02:04:33, Matt Giuca wrote: > Do these need to be added to histograms.xml? We're not planning to measure anything here. So, I think no?
	37 #define IDC_BACKSPACE_FORWARD 33011

36	38

37 // Window management commands	39 // Window management commands

38 #define IDC_NEW_WINDOW 34000	40 #define IDC_NEW_WINDOW 34000

39 #define IDC_NEW_INCOGNITO_WINDOW 34001	41 #define IDC_NEW_INCOGNITO_WINDOW 34001

40 #define IDC_PIN_TO_START_SCREEN 34005	42 #define IDC_PIN_TO_START_SCREEN 34005

41 #define IDC_CLOSE_WINDOW 34012	43 #define IDC_CLOSE_WINDOW 34012

42 #define IDC_ALWAYS_ON_TOP 34013	44 #define IDC_ALWAYS_ON_TOP 34013

43 #define IDC_NEW_TAB 34014	45 #define IDC_NEW_TAB 34014

44 #define IDC_CLOSE_TAB 34015	46 #define IDC_CLOSE_TAB 34015

45 #define IDC_SELECT_NEXT_TAB 34016	47 #define IDC_SELECT_NEXT_TAB 34016

(...skipping 342 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
388 // See http://msdn.microsoft.com/en-us/library/t2zechd4(VS.71).aspx	390 // See http://msdn.microsoft.com/en-us/library/t2zechd4(VS.71).aspx

389	391

390 // Starting command id for menus showing bookmarks (such as the wrench menu).	392 // Starting command id for menus showing bookmarks (such as the wrench menu).

391 // While command ids passed to Windows functions must not be higher than 0xDFFF,	393 // While command ids passed to Windows functions must not be higher than 0xDFFF,

392 // these IDs are not exposed to the native system and thus can be in this	394 // these IDs are not exposed to the native system and thus can be in this

393 // otherwise-reserved range. No command used in a menu (such as the wrench menu)	395 // otherwise-reserved range. No command used in a menu (such as the wrench menu)

394 // should be higher than this, otherwise it'll conflict.	396 // should be higher than this, otherwise it'll conflict.

395 #define IDC_FIRST_BOOKMARK_MENU 0xE000	397 #define IDC_FIRST_BOOKMARK_MENU 0xE000

396	398

397 #endif // CHROME_APP_CHROME_COMMAND_IDS_H_	399 #endif // CHROME_APP_CHROME_COMMAND_IDS_H_

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/app_mode/app_mode_utils.cc » ('j') | chrome/browser/ui/browser_command_controller.cc » ('J')