Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1991963002: (reland) madia: Add helper function to register pepper CDMs (Closed)

Created:
4 years, 7 months ago by xhwang
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, ddorwin
CC:
chromium-reviews, msramek+watch_chromium.org, raymes+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, markusheintz_, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(reland) madia: Add helper function to register pepper CDMs This relands commit eb61e1d9dde1d6c02919c3716a2fd6729267cbac with fix. Original CL description: This removes duplicate pepper CDM registration code. Fix: In chrome_content_renderer_client.cc, we whitelist Widevine CDM using the plugin display name. So in content_settings_browsertest.cc I should pass in the corrent display name for Widevine CDM. TBR=thestig@chromium.org,ddorwin@chromium.org BUG=610581, 582622 Committed: https://crrev.com/b941714542cb1e29df0c5a7b056bd6eb716708ed Cr-Commit-Position: refs/heads/master@{#394574}

Patch Set 1 : original #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -162 lines) Patch
M chrome/browser/content_settings/content_settings_browsertest.cc View 1 5 chunks +12 lines, -54 lines 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 1 3 chunks +7 lines, -56 lines 0 comments Download
M chrome/browser/media/encrypted_media_supported_types_browsertest.cc View 1 8 chunks +15 lines, -52 lines 0 comments Download
A chrome/browser/media/pepper_cdm_test_helper.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/browser/media/pepper_cdm_test_helper.cc View 1 1 chunk +66 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
xhwang
4 years, 7 months ago (2016-05-18 19:48:49 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991963002/20001
4 years, 7 months ago (2016-05-18 19:50:18 UTC) #5
ddorwin
lgtm
4 years, 7 months ago (2016-05-18 20:09:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991963002/20001
4 years, 7 months ago (2016-05-18 20:11:22 UTC) #9
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-18 21:03:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 22:23:58 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 22:25:58 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b941714542cb1e29df0c5a7b056bd6eb716708ed
Cr-Commit-Position: refs/heads/master@{#394574}

Powered by Google App Engine
This is Rietveld 408576698