Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 1991943003: Make username and origin copy-able in the list of passwords. (Closed)

Created:
4 years, 7 months ago by hcarmona
Modified:
4 years, 7 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make username and origin copy-able in the list of passwords. UI doesn't change. This CL makes these 2 sections select-able so they can be copied (keeping old functionality). Headings are not copy-able for consistency w/ rest of UI. BUG=595538 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2d8a49b38c58daee9280ff66935dfb3867af957d Cr-Commit-Position: refs/heads/master@{#394605}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 1 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
hcarmona
PTAL, thanks!
4 years, 7 months ago (2016-05-18 22:00:58 UTC) #3
tommycli
https://codereview.chromium.org/1991943003/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html File chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html (right): https://codereview.chromium.org/1991943003/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html#newcode45 chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:45: .column-header > .username-column, Would it be simpler if we ...
4 years, 7 months ago (2016-05-18 22:36:35 UTC) #4
hcarmona
https://codereview.chromium.org/1991943003/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html File chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html (right): https://codereview.chromium.org/1991943003/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html#newcode45 chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:45: .column-header > .username-column, On 2016/05/18 22:36:35, tommycli wrote: > ...
4 years, 7 months ago (2016-05-18 22:51:16 UTC) #5
tommycli
LGTM!
4 years, 7 months ago (2016-05-18 23:19:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991943003/20001
4 years, 7 months ago (2016-05-18 23:25:18 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 23:49:11 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 23:50:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d8a49b38c58daee9280ff66935dfb3867af957d
Cr-Commit-Position: refs/heads/master@{#394605}

Powered by Google App Engine
This is Rietveld 408576698