Make username and origin copy-able in the list of passwords.

Make username and origin copy-able in the list of passwords.

UI doesn't change. This CL makes these 2 sections select-able so they
can be copied (keeping old functionality). Headings are not copy-able
for consistency w/ rest of UI.

BUG=595538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2d8a49b38c58daee9280ff66935dfb3867af957d
Cr-Commit-Position: refs/heads/master@{#394605}

[hcarmona, 2016-05-18 21:54:24]

Description was changed from

==========
Make username and origin copy-able in the list of passwords.

UI doesn't change. This CL makes these 2 sections select-able so they
can be copied (keeping old functionality). Headings are not copy-able
for consistency w/ rest of UI.

BUG=595538
==========

to

==========
Make username and origin copy-able in the list of passwords.

UI doesn't change. This CL makes these 2 sections select-able so they
can be copied (keeping old functionality). Headings are not copy-able
for consistency w/ rest of UI.

BUG=595538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-05-18 22:00:58]

hcarmona@chromium.org changed reviewers:
+ tommycli@chromium.org

[hcarmona, 2016-05-18 22:00:58]

PTAL, thanks!

[tommycli, 2016-05-18 22:36:35]

https://codereview.chromium.org/1991943003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
(right):

https://codereview.chromium.org/1991943003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:45:
.column-header > .username-column,
Would it be simpler if we just made a 'selectable' class instead of special
casing some username column and website column instances?

[hcarmona, 2016-05-18 22:51:16]

https://codereview.chromium.org/1991943003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
(right):

https://codereview.chromium.org/1991943003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:45:
.column-header > .username-column,
On 2016/05/18 22:36:35, tommycli wrote:
> Would it be simpler if we just made a 'selectable' class instead of special
> casing some username column and website column instances?

Yup, much simpler. Done.

[tommycli, 2016-05-18 23:19:40]

LGTM!

[hcarmona, 2016-05-18 23:24:40]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2016-05-18 23:25:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991943003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991943003/20001

[commit-bot: I haz the power, 2016-05-18 23:49:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-18 23:50:50]

Description was changed from

==========
Make username and origin copy-able in the list of passwords.

UI doesn't change. This CL makes these 2 sections select-able so they
can be copied (keeping old functionality). Headings are not copy-able
for consistency w/ rest of UI.

BUG=595538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Make username and origin copy-able in the list of passwords.

UI doesn't change. This CL makes these 2 sections select-able so they
can be copied (keeping old functionality). Headings are not copy-able
for consistency w/ rest of UI.

BUG=595538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2d8a49b38c58daee9280ff66935dfb3867af957d
Cr-Commit-Position: refs/heads/master@{#394605}
==========

[commit-bot: I haz the power, 2016-05-18 23:50:51]

Patchset 2 (id:??) landed as
https://crrev.com/2d8a49b38c58daee9280ff66935dfb3867af957d
Cr-Commit-Position: refs/heads/master@{#394605}