Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1991933002: Return E_C_T_OFFLINE when the device is offline (Closed)

Created:
4 years, 7 months ago by tbansal1
Modified:
4 years, 7 months ago
Reviewers:
bengr
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return E_C_T_OFFLINE when the device is offline Future CL will add additional logic to return E_C_T_OFFLINE when the device is effectively offline. BUG=612883 Committed: https://crrev.com/bf0c95b52ea71d32c4d5d38083ea978952516b0e Cr-Commit-Position: refs/heads/master@{#394603}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M net/nqe/network_quality_estimator.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 2 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
tbansal1
bengr: ptal. Thanks.
4 years, 7 months ago (2016-05-18 18:21:31 UTC) #5
bengr
lgtm
4 years, 7 months ago (2016-05-18 23:24:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991933002/20001
4 years, 7 months ago (2016-05-18 23:26:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-18 23:44:43 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bf0c95b52ea71d32c4d5d38083ea978952516b0e Cr-Commit-Position: refs/heads/master@{#394603}
4 years, 7 months ago (2016-05-18 23:47:02 UTC) #12
tbansal1
4 years, 7 months ago (2016-05-19 04:16:14 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/1994863002/ by tbansal@chromium.org.

The reason for reverting is: Tests failure 
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Test....
These tests are failing because the device is offline and this CL adds an early
exit in GetEffectiveConnectionType() if the device is offline..

Powered by Google App Engine
This is Rietveld 408576698