Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Side by Side Diff: chrome/BUILD.gn

Issue 1991903002: [Mac/GN] Include Chrome default_apps in the framework bundle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 735 matching lines...) Expand 10 before | Expand all | Expand 10 after
746 746
747 deps = [ 747 deps = [
748 ":chrome_framework_helpers", 748 ":chrome_framework_helpers",
749 ":chrome_framework_locales", 749 ":chrome_framework_locales",
750 ":chrome_framework_plugins", 750 ":chrome_framework_plugins",
751 ":chrome_framework_resources", 751 ":chrome_framework_resources",
752 "//build/config/sanitizers:deps", 752 "//build/config/sanitizers:deps",
753 "//chrome/app/nibs:chrome_xibs", 753 "//chrome/app/nibs:chrome_xibs",
754 ] 754 ]
755 755
756 if (is_chrome_branded) {
757 deps += [ ":default_apps" ]
758 }
759
756 ldflags = [ 760 ldflags = [
757 "-Wl,-install_name,@executable_path/../Versions/$chrome_version_full/$chro me_framework_name.framework/$chrome_framework_name", 761 "-Wl,-install_name,@executable_path/../Versions/$chrome_version_full/$chro me_framework_name.framework/$chrome_framework_name",
758 "-compatibility_version", 762 "-compatibility_version",
759 chrome_dylib_version, 763 chrome_dylib_version,
760 "-current_version", 764 "-current_version",
761 chrome_dylib_version, 765 chrome_dylib_version,
762 "-Wl,-order_file," + rebase_path("app/framework.order", root_build_dir), 766 "-Wl,-order_file," + rebase_path("app/framework.order", root_build_dir),
763 ] 767 ]
764 768
765 if (is_component_build) { 769 if (is_component_build) {
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
952 956
953 if (enable_extensions) { 957 if (enable_extensions) {
954 public_deps += [ 958 public_deps += [
955 "//chrome/browser/resources:quota_internals_resources", 959 "//chrome/browser/resources:quota_internals_resources",
956 "//chrome/browser/resources:sync_file_system_internals_resources", 960 "//chrome/browser/resources:sync_file_system_internals_resources",
957 ] 961 ]
958 } 962 }
959 } 963 }
960 964
961 if (is_chrome_branded) { 965 if (is_chrome_branded) {
962 copy("default_apps") { 966 if (!is_mac) {
967 _default_apps_target_type = "copy"
968 } else {
969 _default_apps_target_type = "bundle_data"
970 }
971
972 target(_default_apps_target_type, "default_apps") {
963 visibility = [ ":packed_resources" ] 973 visibility = [ ":packed_resources" ]
974 if (is_mac) {
975 visibility += [
976 ":chrome_framework",
977 ":chrome_framework_shared_library",
978 ]
979 }
980
964 sources = [ 981 sources = [
965 "browser/resources/default_apps/docs.crx", 982 "browser/resources/default_apps/docs.crx",
966 "browser/resources/default_apps/drive.crx", 983 "browser/resources/default_apps/drive.crx",
967 "browser/resources/default_apps/external_extensions.json", 984 "browser/resources/default_apps/external_extensions.json",
968 "browser/resources/default_apps/gmail.crx", 985 "browser/resources/default_apps/gmail.crx",
969 "browser/resources/default_apps/youtube.crx", 986 "browser/resources/default_apps/youtube.crx",
970 ] 987 ]
971 outputs = [ 988
972 "$root_out_dir/default_apps/{{source_file_part}}", 989 if (!is_mac) {
973 ] 990 outputs = [
991 "$root_out_dir/default_apps/{{source_file_part}}",
992 ]
993 } else {
994 outputs = [
995 "{{bundle_root_dir}}/Deafult Apps/{{source_file_part}}",
996 ]
997 }
974 998
975 # Force anybody that depends on this to get the default apps as data files. 999 # Force anybody that depends on this to get the default apps as data files.
976 data = process_file_template(sources, outputs) 1000 data = process_file_template(sources, outputs)
977 } 1001 }
978 } 1002 }
979 1003
980 group("packed_resources") { 1004 group("packed_resources") {
981 public_deps = [ 1005 public_deps = [
982 ":repack_chrome_100_percent", 1006 ":repack_chrome_100_percent",
983 ":repack_locales_pack", 1007 ":repack_locales_pack",
984 ":repack_pseudo_locales_pack", 1008 ":repack_pseudo_locales_pack",
985 ] 1009 ]
986 1010
987 if (is_chrome_branded) { 1011 if (is_chrome_branded && !is_mac) {
988 public_deps += [ ":default_apps" ] 1012 public_deps += [ ":default_apps" ]
989 } 1013 }
990 1014
991 if (enable_hidpi) { 1015 if (enable_hidpi) {
992 public_deps += [ ":repack_chrome_200_percent" ] 1016 public_deps += [ ":repack_chrome_200_percent" ]
993 } 1017 }
994 1018
995 if (enable_topchrome_md) { 1019 if (enable_topchrome_md) {
996 public_deps += [ ":repack_chrome_material_100_percent" ] 1020 public_deps += [ ":repack_chrome_material_100_percent" ]
997 1021
(...skipping 448 matching lines...) Expand 10 before | Expand all | Expand 10 after
1446 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1470 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1447 "//chrome/tools/build/linux/chrome-wrapper", 1471 "//chrome/tools/build/linux/chrome-wrapper",
1448 "//third_party/xdg-utils/scripts/xdg-mime", 1472 "//third_party/xdg-utils/scripts/xdg-mime",
1449 "//third_party/xdg-utils/scripts/xdg-settings", 1473 "//third_party/xdg-utils/scripts/xdg-settings",
1450 ] 1474 ]
1451 outputs = [ 1475 outputs = [
1452 "$root_out_dir/{{source_file_part}}", 1476 "$root_out_dir/{{source_file_part}}",
1453 ] 1477 ]
1454 } 1478 }
1455 } 1479 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698