[Mac/GN] Setup Keystone for official Chrome builds.

chrome/tools/build/mac/copy_keystone_framework.py

+# Copyright 2016 The Chromium Authors. All rights reserved.

[Mark Mentovai, 2016/05/18 17:53:10]

#!/usr/bin/env python

[Robert Sesek, 2016/05/18 18:36:25]

This isn't done for GN scripts because GN explicitly invokes `python ${script}`
(an action can't invoke a shell script, only Python).

[Mark Mentovai, 2016/05/18 18:40:11]

Then put python in the usage on line 10, because it won’t work as written
otherwise.

[Robert Sesek, 2016/05/18 18:43:45]

Done.

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import os.path
+import shutil
+import subprocess
+import sys
+
+# Usage: copy_keystone_framework.py /path/to/input /path/to/output
+#
+# This script copies the KeystoneRegistration.framework, removing its
+# versioned directory structure, thinning it to just x86_64, and deleting
+# the Headers directory.
+
+def Main(args):
+  if len(args) != 3:
+    print >> sys.stderr, '%s: /path/to/input /path/to/output' % (args[0],)
+    return 1
+
+  # Delete any old copies of the framework.
+  output_path = os.path.join(args[2], 'KeystoneRegistration.framework')
+  if os.path.exists(output_path):
+    shutil.rmtree(output_path)
+
+  # Copy the framework out of its versioned directory.
+  shutil.copytree(os.path.join(args[1], 'Versions/A'), output_path)

[Mark Mentovai, 2016/05/18 17:53:10]

os.readlink(os.path.join(args[1], 'Versions/Current')) and use
Versions/that_thing instead of hard-coding A.

[Robert Sesek, 2016/05/18 18:36:25]

Switched to using rsync and Versions/Current/ so don't need to directly
readlink.

[Mark Mentovai, 2016/05/18 18:40:11]

Robert Sesek wrote:
Cool. The old script needed to readlink for reasons that don’t apply here.
Reading directly through Current is fine.

+
+  # Strip headers from the shipped product.

[Mark Mentovai, 2016/05/18 17:53:10]

Lose PrivateHeaders too, unless it’s an error to rmtree something that’s not
currently there.

I’m also worried about SCM garbage and .DS_Store files. copytree doesn’t give
you much control, can you run a rsync here? You can tell it what you want to
exclude.

[Robert Sesek, 2016/05/18 18:36:25]

Switched to rsync using the same incantation as copy_framework_unversioned.sh.

+  shutil.rmtree(os.path.join(output_path, 'Headers'))
+
+  # Thin the library to just the required arch.
+  library_path = os.path.join(output_path, 'KeystoneRegistration')
+  return subprocess.check_call(

[Mark Mentovai, 2016/05/18 17:53:11]

check_call won’t return nonzero, but hiding that zero in the return doesn’t make
this very obvious. I’d just have a separate “return 0” after this.

[Robert Sesek, 2016/05/18 18:36:25]

Done.

+      ['lipo', '-thin', 'x86_64', library_path, '-o', library_path])
+
+
+if __name__ == '__main__':
+  sys.exit(Main(sys.argv))