Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1831)

Unified Diff: mojo/ui/base_view.cc

Issue 1991853003: Make BaseView et al. take an ApplicationConnector instead of an ApplicationImpl. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: doh Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/ui/base_view.h ('k') | mojo/ui/ganesh_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/ui/base_view.cc
diff --git a/mojo/ui/base_view.cc b/mojo/ui/base_view.cc
index 68611d7f87ad5cee72fd25919b854b83644b428f..124425f57c7b42de636c9b659b91292505a81f4f 100644
--- a/mojo/ui/base_view.cc
+++ b/mojo/ui/base_view.cc
@@ -10,55 +10,52 @@
namespace mojo {
namespace ui {
-BaseView::BaseView(
- mojo::ApplicationImpl* app_impl,
- mojo::InterfaceRequest<mojo::ui::ViewOwner> view_owner_request,
- const std::string& label)
- : app_impl_(app_impl),
+BaseView::BaseView(InterfaceHandle<ApplicationConnector> app_connector,
+ InterfaceRequest<ViewOwner> view_owner_request,
+ const std::string& label)
+ : app_connector_(ApplicationConnectorPtr::Create(app_connector.Pass())),
view_listener_binding_(this),
view_container_listener_binding_(this) {
- DCHECK(app_impl_);
- ConnectToService(app_impl_->shell(), "mojo:view_manager_service",
- mojo::GetProxy(&view_manager_));
+ DCHECK(app_connector_);
+ ConnectToService(app_connector_.get(), "mojo:view_manager_service",
+ GetProxy(&view_manager_));
- mojo::ui::ViewListenerPtr view_listener;
- view_listener_binding_.Bind(mojo::GetProxy(&view_listener));
- view_manager_->CreateView(mojo::GetProxy(&view_), view_owner_request.Pass(),
+ ViewListenerPtr view_listener;
+ view_listener_binding_.Bind(GetProxy(&view_listener));
+ view_manager_->CreateView(GetProxy(&view_), view_owner_request.Pass(),
view_listener.Pass(), label);
- view_->CreateScene(mojo::GetProxy(&scene_));
+ view_->CreateScene(GetProxy(&scene_));
}
BaseView::~BaseView() {}
-mojo::ServiceProvider* BaseView::GetViewServiceProvider() {
+ServiceProvider* BaseView::GetViewServiceProvider() {
if (!view_service_provider_)
- view_->GetServiceProvider(mojo::GetProxy(&view_service_provider_));
+ view_->GetServiceProvider(GetProxy(&view_service_provider_));
return view_service_provider_.get();
}
-mojo::ui::ViewContainer* BaseView::GetViewContainer() {
+ViewContainer* BaseView::GetViewContainer() {
if (!view_container_) {
- view_->GetContainer(mojo::GetProxy(&view_container_));
- mojo::ui::ViewContainerListenerPtr view_container_listener;
- view_container_listener_binding_.Bind(
- mojo::GetProxy(&view_container_listener));
+ view_->GetContainer(GetProxy(&view_container_));
+ ViewContainerListenerPtr view_container_listener;
+ view_container_listener_binding_.Bind(GetProxy(&view_container_listener));
view_container_->SetListener(view_container_listener.Pass());
}
return view_container_.get();
}
void BaseView::OnPropertiesChanged(uint32_t old_scene_version,
- mojo::ui::ViewPropertiesPtr old_properties) {
-}
+ ViewPropertiesPtr old_properties) {}
void BaseView::OnChildAttached(uint32_t child_key,
- mojo::ui::ViewInfoPtr child_view_info) {}
+ ViewInfoPtr child_view_info) {}
void BaseView::OnChildUnavailable(uint32_t child_key) {}
void BaseView::OnPropertiesChanged(
uint32_t scene_version,
- mojo::ui::ViewPropertiesPtr properties,
+ ViewPropertiesPtr properties,
const OnPropertiesChangedCallback& callback) {
DCHECK(properties);
DCHECK(properties->display_metrics);
@@ -66,7 +63,7 @@ void BaseView::OnPropertiesChanged(
DCHECK(properties->view_layout->size);
uint32_t old_scene_version = scene_version_;
- mojo::ui::ViewPropertiesPtr old_properties = properties_.Pass();
+ ViewPropertiesPtr old_properties = properties_.Pass();
scene_version_ = scene_version;
properties_ = properties.Pass();
@@ -75,7 +72,7 @@ void BaseView::OnPropertiesChanged(
}
void BaseView::OnChildAttached(uint32_t child_key,
- mojo::ui::ViewInfoPtr child_view_info,
+ ViewInfoPtr child_view_info,
const OnChildUnavailableCallback& callback) {
DCHECK(child_view_info);
« no previous file with comments | « mojo/ui/base_view.h ('k') | mojo/ui/ganesh_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698