Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1991853003: Make BaseView et al. take an ApplicationConnector instead of an ApplicationImpl. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan, jeffbrown
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make BaseView et al. take an ApplicationConnector instead of an ApplicationImpl. In general, it's a bit of a layering violation to pass around ApplicationImpl*'s, and it also poses some lifetime issues. (Using ApplicationConnectors resolves any potential lifetime issues.) Mostly though, I want to rework the way ApplicationImpl, etc. work, and this gets in the way. R=jeffbrown@google.com Committed: https://chromium.googlesource.com/external/mojo/+/4ade0ed278a8a25b32ded431c3c7859899115b53

Patch Set 1 #

Patch Set 2 : doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -127 lines) Patch
M apps/moterm/moterm_app.cc View 2 chunks +3 lines, -1 line 0 comments Download
M apps/moterm/moterm_view.h View 1 chunk +1 line, -1 line 0 comments Download
M apps/moterm/moterm_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/shadows/shadows_app.cc View 2 chunks +3 lines, -1 line 0 comments Download
M examples/shadows/shadows_view.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/shadows/shadows_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/ui/jank/jank.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M examples/ui/noodles/noodles_app.cc View 2 chunks +3 lines, -1 line 0 comments Download
M examples/ui/noodles/noodles_view.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/noodles/noodles_view.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M examples/ui/pdf_viewer/pdf_viewer.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M examples/ui/png_viewer/png_viewer.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M examples/ui/shapes/shapes_app.cc View 2 chunks +3 lines, -1 line 0 comments Download
M examples/ui/shapes/shapes_view.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/shapes/shapes_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/ui/spinning_cube/spinning_cube_app.cc View 2 chunks +3 lines, -1 line 0 comments Download
M examples/ui/spinning_cube/spinning_cube_view.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/spinning_cube/spinning_cube_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/ui/tile/tile_app.cc View 2 chunks +3 lines, -1 line 0 comments Download
M examples/ui/tile/tile_view.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/tile/tile_view.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/connect.h View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/public/cpp/application/lib/connect.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/ui/base_view.h View 3 chunks +28 lines, -32 lines 0 comments Download
M mojo/ui/base_view.cc View 3 chunks +22 lines, -25 lines 0 comments Download
M mojo/ui/ganesh_view.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M mojo/ui/ganesh_view.cc View 1 chunk +6 lines, -11 lines 0 comments Download
M mojo/ui/gl_view.h View 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/ui/gl_view.cc View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
viettrungluu
(jeff or vardhan, whoever gets to this first)
4 years, 7 months ago (2016-05-18 18:03:16 UTC) #3
jeffbrown
lgtm
4 years, 7 months ago (2016-05-18 22:00:49 UTC) #4
viettrungluu
4 years, 7 months ago (2016-05-18 22:55:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4ade0ed278a8a25b32ded431c3c7859899115b53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698