Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1991843003:
Refactor PointerUpdatingVisitor. (Closed)
DescriptionRefactor PointerUpdatingVisitor.
This patch extracts typed slot processing logic from
the PointerUpdatingVisitor to a set of functions.
Each of these functions takes an untyped slot processing function
and applies it to a typed slot.
BUG=chromium:612847
LOG=NO
Committed: https://crrev.com/c3a906d53bbb5da277e95d547cb0abef56b1ae46
Cr-Commit-Position: refs/heads/master@{#36357}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #
Total comments: 5
Patch Set 4 : Address comments #Patch Set 5 : #Messages
Total messages: 19 (9 generated)
Description was changed from ========== Refactor PointerUpdatingVisitor. BUG= ========== to ========== Refactor PointerUpdatingVisitor. This patch extracts typed slot processing logic from the PointerUpdatingVisitor to a set of functions. Each of these functions takes an untyped slot processing function and applies it to a typed slot. BUG=chromium:612847 LOG=NO ==========
ulan@chromium.org changed reviewers: + ahaas@chromium.org, mlippautz@chromium.org
ptal https://codereview.chromium.org/1991843003/diff/40001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1991843003/diff/40001/src/heap/mark-compact.c... src/heap/mark-compact.cc:2802: static inline SlotCallbackResult UpdateSlot(Heap* heap, Object** slot) { I just moved this function and changed its type from void to SlotCallbackResult.
https://codereview.chromium.org/1991843003/diff/40001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1991843003/diff/40001/src/heap/mark-compact.c... src/heap/mark-compact.cc:2810: DCHECK(heap->InFromSpace(heap_obj) || you could get the heap from heap_obj->GetHeap() https://codereview.chromium.org/1991843003/diff/40001/src/heap/mark-compact.c... src/heap/mark-compact.cc:2845: Object* code = Code::GetObjectFromEntryAddress(entry_address); Why do you not do the DCHECK here?
lgtm
lgtm
Thanks! https://codereview.chromium.org/1991843003/diff/40001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1991843003/diff/40001/src/heap/mark-compact.c... src/heap/mark-compact.cc:2810: DCHECK(heap->InFromSpace(heap_obj) || On 2016/05/19 08:48:44, ahaas wrote: > you could get the heap from heap_obj->GetHeap() Done :) https://codereview.chromium.org/1991843003/diff/40001/src/heap/mark-compact.c... src/heap/mark-compact.cc:2845: Object* code = Code::GetObjectFromEntryAddress(entry_address); On 2016/05/19 08:48:44, ahaas wrote: > Why do you not do the DCHECK here? There is not reloc info.
The CQ bit was checked by ulan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mlippautz@chromium.org, ahaas@chromium.org Link to the patchset: https://codereview.chromium.org/1991843003/#ps60001 (title: "Address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991843003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991843003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
The CQ bit was checked by ulan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mlippautz@chromium.org, ahaas@chromium.org Link to the patchset: https://codereview.chromium.org/1991843003/#ps80001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991843003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991843003/80001
Message was sent while issue was closed.
Description was changed from ========== Refactor PointerUpdatingVisitor. This patch extracts typed slot processing logic from the PointerUpdatingVisitor to a set of functions. Each of these functions takes an untyped slot processing function and applies it to a typed slot. BUG=chromium:612847 LOG=NO ========== to ========== Refactor PointerUpdatingVisitor. This patch extracts typed slot processing logic from the PointerUpdatingVisitor to a set of functions. Each of these functions takes an untyped slot processing function and applies it to a typed slot. BUG=chromium:612847 LOG=NO ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Refactor PointerUpdatingVisitor. This patch extracts typed slot processing logic from the PointerUpdatingVisitor to a set of functions. Each of these functions takes an untyped slot processing function and applies it to a typed slot. BUG=chromium:612847 LOG=NO ========== to ========== Refactor PointerUpdatingVisitor. This patch extracts typed slot processing logic from the PointerUpdatingVisitor to a set of functions. Each of these functions takes an untyped slot processing function and applies it to a typed slot. BUG=chromium:612847 LOG=NO Committed: https://crrev.com/c3a906d53bbb5da277e95d547cb0abef56b1ae46 Cr-Commit-Position: refs/heads/master@{#36357} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/c3a906d53bbb5da277e95d547cb0abef56b1ae46 Cr-Commit-Position: refs/heads/master@{#36357} |
