Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1991823004: Fix spelling of a few histograms. (Closed)

Created:
4 years, 7 months ago by Julia Tuttle
Modified:
4 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix spelling of a few histograms. I added a bunch of histograms in https://crrev.com/1908543002/, but misspelled (or forgot to rename) a few, and the presubmit didn't catch them because they were logged through a macro. BUG=605138 Committed: https://crrev.com/abd7fc83302b46dba0835405767e9bc6e9a332e0 Cr-Commit-Position: refs/heads/master@{#395410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M net/dns/host_cache.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Julia Tuttle
PTAL, rdsmith.
4 years, 7 months ago (2016-05-20 16:24:47 UTC) #2
Randy Smith (Not in Mondays)
So just confirming: Everything touched in here is in histograms.xml in its new name already?
4 years, 7 months ago (2016-05-21 21:00:33 UTC) #3
Julia Tuttle
On 2016/05/21 21:00:33, Randy Smith - Not in Fridays wrote: > So just confirming: Everything ...
4 years, 7 months ago (2016-05-23 13:42:33 UTC) #4
Randy Smith (Not in Mondays)
lgtm
4 years, 7 months ago (2016-05-23 19:49:07 UTC) #5
Julia Tuttle
On 2016/05/23 19:49:07, Randy Smith - Not in Fridays wrote: > lgtm Thanks, Randy!
4 years, 7 months ago (2016-05-23 19:54:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991823004/1
4 years, 7 months ago (2016-05-23 19:54:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 21:07:56 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 21:10:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abd7fc83302b46dba0835405767e9bc6e9a332e0
Cr-Commit-Position: refs/heads/master@{#395410}

Powered by Google App Engine
This is Rietveld 408576698