chrome/browser/ui/cocoa/browser_window_controller.mm - Issue 19918002: Refactor [FramedBrowserWindow drawWindowThemeInDirtyRect:] to use themeImagePositionForAlignment:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 19918002: Refactor [FramedBrowserWindow drawWindowThemeInDirtyRect:] to use themeImagePositionForAlignment: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.h ('k') | chrome/browser/ui/cocoa/browser_window_utils.h » ('j') | chrome/browser/ui/cocoa/browser_window_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm

index bef4fa989d55a8dd1a622fc8e32b1e93301225da..b16152b0695eb122b4e520664cc40caa419ecfd4 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm

@@ -1660,13 +1660,14 @@ enum {

return style;

}

-- (NSPoint)themePatternPhaseForAlignment:(ThemePatternAlignment)alignment {

+- (NSPoint)themeImagePositionForAlignment:(ThemeImageAlignment)alignment {

NSView* windowChromeView = [[[self window] contentView] superview];

NSView* tabStripView = nil;

- if (alignment == THEME_PATTERN_ALIGN_WITH_TAB_STRIP && [self hasTabStrip])

+ if ([self hasTabStrip])

tabStripView = [self tabStripView];

- return [BrowserWindowUtils themePatternPhaseFor:windowChromeView

- withTabStrip:tabStripView];

+ return [BrowserWindowUtils themeImagePositionFor:windowChromeView

+ withTabStrip:tabStripView

+ alignment:alignment];

}

- (NSPoint)bookmarkBubblePoint {