Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1991793002: [serializer] cosmetic changes to SerializerReference. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] cosmetic changes to SerializerReference. R=vogelheim@chromium.org Committed: https://crrev.com/2b60b3580eada118f81a3fb377d6eb9fa851c767 Cr-Commit-Position: refs/heads/master@{#36327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M src/address-map.h View 5 chunks +13 lines, -9 lines 0 comments Download
M src/snapshot/deserializer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
https://codereview.chromium.org/1992723002/ landed without the second patch set, for which I created this CL.
4 years, 7 months ago (2016-05-18 12:01:13 UTC) #1
vogelheim
lgtm
4 years, 7 months ago (2016-05-18 14:07:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991793002/1
4 years, 7 months ago (2016-05-18 14:07:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 14:38:48 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 14:39:50 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2b60b3580eada118f81a3fb377d6eb9fa851c767
Cr-Commit-Position: refs/heads/master@{#36327}

Powered by Google App Engine
This is Rietveld 408576698