Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1991773002: [Win] deviceorientation: fix euler angles order. (Closed)

Created:
4 years, 7 months ago by timvolodine
Modified:
4 years, 7 months ago
CC:
chromium-reviews, riju_, Michael van Ouwerkerk, jam, timvolodine, darin-cc_chromium.org, mlamouri+watch-sensors_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Win] deviceorientation: fix euler angles order. Currently the alpha, beta and gamma angles are not reported in correct order. This patch fixes this. On windows the following applies: Z-axis - alpha, X-axis - beta, Y-axis - gamma. BUG=612434 Committed: https://crrev.com/28728e3f6dd412ae82ae14b9c14036e545cc881b Cr-Commit-Position: refs/heads/master@{#394442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/browser/device_sensors/data_fetcher_shared_memory_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
timvolodine
sorry, one more fix for M52 ;)
4 years, 7 months ago (2016-05-18 11:37:09 UTC) #3
Michael van Ouwerkerk
lgtm
4 years, 7 months ago (2016-05-18 11:49:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991773002/1
4 years, 7 months ago (2016-05-18 16:07:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 16:48:30 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 16:49:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28728e3f6dd412ae82ae14b9c14036e545cc881b
Cr-Commit-Position: refs/heads/master@{#394442}

Powered by Google App Engine
This is Rietveld 408576698