Replace Utf8Value() with a more efficient method

Replace Utf8Value() with a more efficient method

Utf8Value was replaced in the following functions:
  Runtime_CanonicalizeLanguageTag
  GetLanguageTagVariants
  Runtime_InternalDateParse


BUG=v8:4983
TEST=intl/numberformat/parse*, intl/dateformat/parse*
TEST=test262/intl402/6.2.2_a, test262/intl402/9.2.1_3
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng

[jungshik at Google, 2016-05-18 17:31:09]

Description was changed from

==========
Replace Utf8Valeu() with a more efficient method



BUG=4983
==========

to

==========
Replace Utf8Valeu() with a more efficient method



BUG=4983
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng
==========

[jungshik at Google, 2016-05-18 21:17:29]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-18 21:17:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991753002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991753002/1

[jungshik at Google, 2016-05-18 21:29:25]

Description was changed from

==========
Replace Utf8Valeu() with a more efficient method



BUG=4983
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng
==========

to

==========
Replace Utf8Valeu() with a more efficient method



BUG=4983
TEST=intl/numberformat/parse*, intl/dateformat/parse*
TEST=test262/intl402/6.2.2_a, test262/intl402/9.2.1_3
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng
==========

[jungshik at Google, 2016-05-18 21:36:17]

Description was changed from

==========
Replace Utf8Valeu() with a more efficient method



BUG=4983
TEST=intl/numberformat/parse*, intl/dateformat/parse*
TEST=test262/intl402/6.2.2_a, test262/intl402/9.2.1_3
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng
==========

to

==========
Replace Utf8Value() with a more efficient method

Utf8Value was replaced in the following functions:
  Runtime_CanonicalizeLanguageTag
  GetLanguageTagVariants
  Runtime_InternalDateParse


BUG=4983
TEST=intl/numberformat/parse*, intl/dateformat/parse*
TEST=test262/intl402/6.2.2_a, test262/intl402/9.2.1_3
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng
==========

[jungshik at Google, 2016-05-18 21:37:01]

The CQ bit was checked by jshin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-18 21:37:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991753002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991753002/20001

[jungshik at Google, 2016-05-18 21:37:41]

jshin@chromium.org changed reviewers:
+ littledan@chromium.org, yangguo@chromium.org

[jungshik at Google, 2016-05-18 21:37:42]

PTAL. Thanks

[Dan Ehrenberg, 2016-05-18 21:42:04]

If the motivation is performance, do you have any performance test results?
Microbenchmarks?

[commit-bot: I haz the power, 2016-05-18 22:38:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 22:38:49]

Dry run: This issue passed the CQ dry run.

[jungshik at Google, 2016-05-18 22:44:03]

On 2016/05/18 21:42:04, Dan Ehrenberg wrote:
> If the motivation is performance, do you have any performance test results?
> Microbenchmarks?

Not yet. I'll produce one.

[Yang, 2016-05-23 08:09:42]

Description was changed from

==========
Replace Utf8Value() with a more efficient method

Utf8Value was replaced in the following functions:
  Runtime_CanonicalizeLanguageTag
  GetLanguageTagVariants
  Runtime_InternalDateParse


BUG=4983
TEST=intl/numberformat/parse*, intl/dateformat/parse*
TEST=test262/intl402/6.2.2_a, test262/intl402/9.2.1_3
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng
==========

to

==========
Replace Utf8Value() with a more efficient method

Utf8Value was replaced in the following functions:
  Runtime_CanonicalizeLanguageTag
  GetLanguageTagVariants
  Runtime_InternalDateParse


BUG=v8:4983
TEST=intl/numberformat/parse*, intl/dateformat/parse*
TEST=test262/intl402/6.2.2_a, test262/intl402/9.2.1_3
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng
==========

[Yang, 2016-05-30 11:01:49]

https://codereview.chromium.org/1991753002/diff/20001/src/runtime/runtime-i18...
File src/runtime/runtime-i18n.cc (right):

https://codereview.chromium.org/1991753002/diff/20001/src/runtime/runtime-i18...
src/runtime/runtime-i18n.cc:70: CopyChars(dest, flat.ToUC16Vector().start(),
length);
Do we not care about clamping uc16 characters to char? This could give false
positives. For example "\uAB64\uAB65-DE" would result in the same as "de-DE".

https://codereview.chromium.org/1991753002/diff/20001/src/runtime/runtime-i18...
src/runtime/runtime-i18n.cc:84: // CONVERT_ARG_HANDLE_CHECKED(SeqOneByteString,
locale_id_str, 0);
Please remove this line.