Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 1991703003: [Layout API] Use FrameView::layoutViewItem() in SimCompositor.cpp (Closed)

Created:
4 years, 7 months ago by pilgrim_google
Modified:
4 years, 7 months ago
Reviewers:
eae, jsbell
CC:
blink-reviews, chromium-reviews, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Use FrameView::layoutViewItem() in SimCompositor.cpp There was a single reference to layoutView() which can be replaced 1-1 with layoutViewItem(). No new API methods are required. BUG=499321 Committed: https://crrev.com/0f0817051fe884460ccdade3bc5121bf72742bf7 Cr-Commit-Position: refs/heads/master@{#394803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/web/tests/sim/SimCompositor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pilgrim_google
4 years, 7 months ago (2016-05-18 17:58:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991703003/1
4 years, 7 months ago (2016-05-19 13:59:14 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-19 13:59:16 UTC) #6
eae
lgtm
4 years, 7 months ago (2016-05-19 16:22:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991703003/1
4 years, 7 months ago (2016-05-19 16:23:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 17:24:57 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 17:27:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f0817051fe884460ccdade3bc5121bf72742bf7
Cr-Commit-Position: refs/heads/master@{#394803}

Powered by Google App Engine
This is Rietveld 408576698