Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19917006: Move all googletest related scripts into googletest/ (Closed)

Created:
7 years, 5 months ago by M-A Ruel
Modified:
7 years, 5 months ago
Reviewers:
csharp
CC:
chromium-reviews, csharp+cc_chromium.org, vadimsh+cc_chromium.org, maruel+cc_chromium.org
Visibility:
Public.

Description

Move all googletest related scripts into googletest/ Move unit and smoke tests accordingly. R=csharp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=213621

Patch Set 1 #

Patch Set 2 : cleaner #

Patch Set 3 : update README.py #

Total comments: 2

Patch Set 4 : Remove unnecessary pylint warning disable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -5378 lines) Patch
M PRESUBMIT.py View 2 chunks +8 lines, -0 lines 0 comments Download
M README.py View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
D fix_test_cases.py View 1 chunk +0 lines, -235 lines 0 comments Download
A googletest/README.py View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A + googletest/fix_test_cases.py View 3 chunks +8 lines, -3 lines 0 comments Download
A + googletest/isolate_test_cases.py View 5 chunks +9 lines, -6 lines 0 comments Download
A + googletest/list_test_cases.py View 1 chunk +7 lines, -2 lines 0 comments Download
A + googletest/run_test_cases.py View 2 chunks +5 lines, -4 lines 0 comments Download
A + googletest/shard_test_cases.py View 2 chunks +5 lines, -11 lines 0 comments Download
A + googletest/tests/fix_test_cases_smoke_test.py View 4 chunks +13 lines, -6 lines 0 comments Download
A + googletest/tests/gtest_fake/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/gtest_fake/expected.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/gtest_fake/gtest_fake_base.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/gtest_fake/gtest_fake_confused_fail.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/gtest_fake/gtest_fake_confused_pass.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/gtest_fake/gtest_fake_crash_after_pass.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/gtest_fake/gtest_fake_error.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/gtest_fake/gtest_fake_fail.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/gtest_fake/gtest_fake_flaky.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/gtest_fake/gtest_fake_missing.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/gtest_fake/gtest_fake_pass.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/gtest_fake/gtest_fake_slow.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/isolate_test_cases/gtest_fake_pass.isolate View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/isolate_test_cases_smoke_test.py View 5 chunks +13 lines, -10 lines 0 comments Download
A + googletest/tests/list_test_cases_smoke_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/run_test_cases/output.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/run_test_cases_smoke_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + googletest/tests/run_test_cases_test.py View 1 chunk +2 lines, -1 line 0 comments Download
A + googletest/tests/trace_test_cases_smoke_test.py View 5 chunks +6 lines, -5 lines 0 comments Download
A + googletest/trace_test_cases.py View 3 chunks +7 lines, -5 lines 0 comments Download
D isolate_test_cases.py View 1 chunk +0 lines, -167 lines 0 comments Download
D list_test_cases.py View 1 chunk +0 lines, -48 lines 0 comments Download
D run_test_cases.py View 1 chunk +0 lines, -1672 lines 0 comments Download
D shard_test_cases.py View 1 chunk +0 lines, -52 lines 0 comments Download
D tests/fix_test_cases_smoke_test.py View 1 chunk +0 lines, -168 lines 0 comments Download
D tests/gtest_fake/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/gtest_fake/expected.xml View 1 chunk +0 lines, -65 lines 0 comments Download
D tests/gtest_fake/gtest_fake_base.py View 1 chunk +0 lines, -81 lines 0 comments Download
D tests/gtest_fake/gtest_fake_confused_fail.py View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/gtest_fake/gtest_fake_confused_pass.py View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/gtest_fake/gtest_fake_crash_after_pass.py View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/gtest_fake/gtest_fake_error.py View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/gtest_fake/gtest_fake_fail.py View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/gtest_fake/gtest_fake_flaky.py View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/gtest_fake/gtest_fake_missing.py View 1 chunk +0 lines, -46 lines 0 comments Download
D tests/gtest_fake/gtest_fake_pass.py View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/gtest_fake/gtest_fake_slow.py View 1 chunk +0 lines, -34 lines 0 comments Download
D tests/isolate_test_cases/gtest_fake_pass.isolate View 1 chunk +0 lines, -13 lines 0 comments Download
D tests/isolate_test_cases_smoke_test.py View 1 chunk +0 lines, -213 lines 0 comments Download
D tests/list_test_cases_smoke_test.py View 1 chunk +0 lines, -40 lines 0 comments Download
M tests/run_isolated/check_files.isolated View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tests/run_isolated/check_files.py View 1 chunk +2 lines, -1 line 0 comments Download
D tests/run_isolated/gtest_fake.isolated View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/run_isolated/gtest_fake.py View 1 chunk +0 lines, -84 lines 0 comments Download
M tests/run_isolated/regen_test_data.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/run_isolated_smoke_test.py View 3 chunks +19 lines, -15 lines 0 comments Download
D tests/run_test_cases/output.py View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/run_test_cases_smoke_test.py View 1 chunk +0 lines, -832 lines 0 comments Download
D tests/run_test_cases_test.py View 1 chunk +0 lines, -880 lines 0 comments Download
M tests/trace_inputs_smoke_test.py View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/trace_inputs_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
D tests/trace_test_cases_smoke_test.py View 1 chunk +0 lines, -167 lines 0 comments Download
D trace_test_cases.py View 1 chunk +0 lines, -202 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
In the end, it should be a net benefit. It results in a strict separation ...
7 years, 5 months ago (2013-07-24 19:30:43 UTC) #1
csharp
LGTM with one nit https://codereview.chromium.org/19917006/diff/4001/googletest/README.py File googletest/README.py (right): https://codereview.chromium.org/19917006/diff/4001/googletest/README.py#newcode11 googletest/README.py:11: # Line too long (NN/80) ...
7 years, 5 months ago (2013-07-24 20:21:16 UTC) #2
M-A Ruel
https://codereview.chromium.org/19917006/diff/4001/googletest/README.py File googletest/README.py (right): https://codereview.chromium.org/19917006/diff/4001/googletest/README.py#newcode11 googletest/README.py:11: # Line too long (NN/80) On 2013/07/24 20:21:16, csharp ...
7 years, 5 months ago (2013-07-24 20:29:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/19917006/10001
7 years, 5 months ago (2013-07-25 13:31:09 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-25 13:34:11 UTC) #5
Message was sent while issue was closed. 
Change committed as 213621

Powered by Google App Engine
This is Rietveld 408576698