Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1991663002: X87: [es6] Reintroduce the instanceof operator in the backends. (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Reintroduce the instanceof operator in the backends. port 551e0aa11bf4b97f9d38c4ce0c5aac89df0a773a (r36275) original commit message: This adds back the instanceof operator support in the backends and introduces a @@hasInstance protector cell on the isolate that guards the fast path for the InstanceOfStub. This way we recover the ~10% regression on Octane EarleyBoyer in Crankshaft and greatly improve TurboFan and Ignition performance of instanceof. BUG= Committed: https://crrev.com/529e333258e52295325c046f4157bd033d1f7de7 Cr-Commit-Position: refs/heads/master@{#36303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -195 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 2 chunks +0 lines, -17 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -123 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-05-18 02:50:05 UTC) #2
Weiliang
lgtm
4 years, 7 months ago (2016-05-18 04:10:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991663002/1
4 years, 7 months ago (2016-05-18 05:16:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 05:45:19 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 05:45:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/529e333258e52295325c046f4157bd033d1f7de7
Cr-Commit-Position: refs/heads/master@{#36303}

Powered by Google App Engine
This is Rietveld 408576698