components/content_settings/core/browser/website_settings_registry_unittest.cc - Issue 1991623005: Only Register() platform specific content settings types on different platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/website_settings_registry_unittest.cc

Issue 1991623005: Only Register() platform specific content settings types on different platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/content_settings/core/browser/website_settings_registry.cc ('K') | « components/content_settings/core/browser/website_settings_registry.cc ('k') | components/content_settings/core/common/content_settings_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/website_settings_registry_unittest.cc

diff --git a/components/content_settings/core/browser/website_settings_registry_unittest.cc b/components/content_settings/core/browser/website_settings_registry_unittest.cc

index d79ba248162047ec980015f087185e0aedd29bb6..c5fddecd81666f6627a691f6f8f7476fa8200111 100644

--- a/components/content_settings/core/browser/website_settings_registry_unittest.cc

+++ b/components/content_settings/core/browser/website_settings_registry_unittest.cc

@@ -49,6 +49,7 @@ TEST_F(WebsiteSettingsRegistryTest, GetByName) {

WebsiteSettingsInfo::UNSYNCABLE,

WebsiteSettingsInfo::LOSSY,

WebsiteSettingsInfo::TOP_LEVEL_DOMAIN_ONLY_SCOPE,

+ WebsiteSettingsInfo::ALL_PLATFORMS,

WebsiteSettingsInfo::INHERIT_IN_INCOGNITO);

info = registry()->GetByName("test");

ASSERT_TRUE(info);

@@ -75,6 +76,7 @@ TEST_F(WebsiteSettingsRegistryTest, Properties) {

WebsiteSettingsInfo::SYNCABLE,

WebsiteSettingsInfo::LOSSY,

WebsiteSettingsInfo::TOP_LEVEL_DOMAIN_ONLY_SCOPE,

+ WebsiteSettingsInfo::ALL_PLATFORMS,

WebsiteSettingsInfo::INHERIT_IN_INCOGNITO);

info = registry()->Get(static_cast<ContentSettingsType>(10));

ASSERT_TRUE(info);

@@ -99,6 +101,7 @@ TEST_F(WebsiteSettingsRegistryTest, Iteration) {

WebsiteSettingsInfo::SYNCABLE,

WebsiteSettingsInfo::LOSSY,

WebsiteSettingsInfo::TOP_LEVEL_DOMAIN_ONLY_SCOPE,

+ WebsiteSettingsInfo::ALL_PLATFORMS,

WebsiteSettingsInfo::INHERIT_IN_INCOGNITO);

bool found = false;