Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: components/content_settings/core/browser/content_settings_registry_unittest.cc

Issue 1991623005: Only Register() platform specific content settings types on different platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/content_settings_registry_unittest.cc
diff --git a/components/content_settings/core/browser/content_settings_registry_unittest.cc b/components/content_settings/core/browser/content_settings_registry_unittest.cc
index 4184b8c99a29ef3a4b54661777100a8f865170a0..65b0f706229fe1f84a8d190f059fb7378ede566c 100644
--- a/components/content_settings/core/browser/content_settings_registry_unittest.cc
+++ b/components/content_settings/core/browser/content_settings_registry_unittest.cc
@@ -4,7 +4,7 @@
#include <string>
#include <vector>
-
+#include <iostream>
#include "base/logging.h"
#include "base/values.h"
#include "components/content_settings/core/browser/content_settings_info.h"
@@ -76,6 +76,7 @@ TEST_F(ContentSettingsRegistryTest, Iteration) {
bool cookies_found = false;
for (const ContentSettingsInfo* info : *registry()) {
ContentSettingsType type = info->website_settings_info()->type();
+ std::cout << "##########lshang#########" << type << std::endl;
EXPECT_EQ(registry()->Get(type), info);
if (type == CONTENT_SETTINGS_TYPE_PLUGINS) {
EXPECT_FALSE(plugins_found);
@@ -86,7 +87,12 @@ TEST_F(ContentSettingsRegistryTest, Iteration) {
}
}
+#if defined(OS_ANDROID) || defined(OS_IOS)
+ EXPECT_FALSE(plugins_found);
+#else
EXPECT_TRUE(plugins_found);
+#endif
+
EXPECT_TRUE(cookies_found);
}

Powered by Google App Engine
This is Rietveld 408576698