Only Register() platform specific content settings types on different platforms

components/content_settings/core/browser/website_settings_info.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_WEBSITE_SETTINGS_INFO_H_
 #define COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_WEBSITE_SETTINGS_INFO_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 32 matching lines @@
   };
 
   enum IncognitoBehavior {
     // Settings will be inherited from regular to incognito profiles as usual.
     INHERIT_IN_INCOGNITO,
 
     // Settings will not be inherited from regular to incognito profiles.
     DONT_INHERIT_IN_INCOGNITO,
   };
 
+  enum AppliedPlatform {

[raymes, 2016/05/20 19:10:16]

nit: Maybe just Platform?

I wonder if we should move this into WebsiteSettingsRegistry since it's not
actually used in this file.

It feels like we should have a bitmask here with DESKTOP defined in terms of
windows, linux, chromeos and mac. It would make the code which checks the
platform simpler and it would avoid having to add more values to this enum in
the future. I don't think it would be much more complicated. See e.g.
https://code.google.com/p/chromium/codesearch#chromium/src/components/pref_re...

Also as I thought about it more I'm not sure this is a good long-term solution.
I think long term each content setting should be registered from within the
component/code where it is used. Then each component could ifdef its own content
settings depending on the platforms on which the component is used. That is a
more modular approach. However I think this is good for now. Let's add a TODO,
something like:
// TODO(...): Remove this enum when content settings can be registered from
within the component in which they are used. When this is possible then ifdefs
can be contained within each component.

[lshang, 2016/05/24 11:55:45]

Done.

+    // Settings applied to all platforms, including win, mac, linux, chromeos,
+    // android, ios.
+    ALL_PLATFORMS,
+
+    // Settings only applied to win, mac, linux and chromeos.
+    DESKTOP_ONLY,
+
+    // Settings applied to win, mac, linux, chromeos and android, but not ios.
+    DESKTOP_AND_ANDROID_ONLY,
+
+    // Settings only applied to android and chromeos.
+    ANDROID_AND_CHROMEOS_ONLY
+  };
+
   WebsiteSettingsInfo(ContentSettingsType type,
                       const std::string& name,
                       std::unique_ptr<base::Value> initial_default_value,
                       SyncStatus sync_status,
                       LossyStatus lossy_status,
                       ScopingType scoping_type,
                       IncognitoBehavior incognito_behavior);
   ~WebsiteSettingsInfo();
 
   ContentSettingsType type() const { return type_; }
@@ skipping 23 matching lines @@
   const LossyStatus lossy_status_;
   const ScopingType scoping_type_;
   const IncognitoBehavior incognito_behavior_;
 
   DISALLOW_COPY_AND_ASSIGN(WebsiteSettingsInfo);
 };
 
 }  // namespace content_settings
 
 #endif  // COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_WEBSITE_SETTINGS_INFO_H_