Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1991603002: Move the FileAPI directory from web-platform-tests/ to wpt/. (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews, tfarina, blink-reviews-w3ctests_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the FileAPI directory from web-platform-tests/ to wpt/. BUG=611762 Committed: https://crrev.com/6fa1026b31062bec76795a981bdb04b14328c59f Cr-Commit-Position: refs/heads/master@{#394925}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : #

Patch Set 5 : Added FileAPI/blob/Blob-constructor.html failure expectation #

Patch Set 6 : Move platform-specific expectations for FileAPI #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-46 lines, -2398 lines) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/WPTServeExpectations View 1 2 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/BlobURL/support/file_test1.js View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/BlobURL/support/file_test2.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/BlobURL/support/file_test3.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/FileReader/Progress_event_bubbles_cancelable.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/FileReader/support/file_test1.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/FileReaderSync.worker.js View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-XHR-revoke.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-XHR-revoke-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-close.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-close-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-constructor.html View 1 chunk +0 lines, -495 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-constructor-expected.txt View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-in-worker.worker.js View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-slice.html View 1 chunk +0 lines, -214 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-slice-expected.txt View 1 chunk +0 lines, -127 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-slice-overflow.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/file/File-constructor.html View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/file/File-constructor-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/file/Worker-read-file-constructor.worker.js View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/fileReader.html View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/fileReader-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/filelist-section/filelist.html View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/filelist-section/support/upload.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/filelist-section/support/upload.zip View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/historical.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/historical-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/idlharness.html View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/idlharness.idl View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/idlharness-expected.txt View 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/idlharness.worker.js View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/Determining-Encoding.html View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/FileReader-event-handler-attributes.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/FileReader-multiple-reads.html View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/FileReader-multiple-reads-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/filereader_abort.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/filereader_error.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/filereader_readAsArrayBuffer.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/filereader_readAsDataURL.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/filereader_readAsText.html View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/filereader_readystate.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/filereader_result.html View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/support/blue-100x100.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/support/Blob.js View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/support/upload.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/url/url_createobjecturl_blob.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/url/url_createobjecturl_blob-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/url/url_xmlhttprequest.html View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/web-platform-tests/FileAPI/url/url_xmlhttprequest-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/BlobURL/support/file_test1.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/BlobURL/support/file_test2.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/BlobURL/support/file_test3.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/FileReader/Progress_event_bubbles_cancelable.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/FileReader/support/file_test1.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/FileReaderSync.worker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/blob/Blob-XHR-revoke.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/blob/Blob-XHR-revoke-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/blob/Blob-close.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/blob/Blob-close-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/blob/Blob-constructor.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/blob/Blob-constructor-expected.txt View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/blob/Blob-in-worker.worker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/blob/Blob-slice.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/blob/Blob-slice-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/blob/Blob-slice-overflow.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/file/File-constructor.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/file/File-constructor-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/file/Worker-read-file-constructor.worker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/fileReader.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/fileReader-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/filelist-section/filelist.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/filelist-section/support/upload.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/filelist-section/support/upload.zip View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/historical.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/historical-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/idlharness.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/idlharness.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/idlharness-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/idlharness.worker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/Determining-Encoding.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/FileReader-event-handler-attributes.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/FileReader-multiple-reads.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/FileReader-multiple-reads-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/filereader_abort.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/filereader_error.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/filereader_readAsArrayBuffer.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/filereader_readAsDataURL.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/filereader_readAsText.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/filereader_readystate.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/filereader_result.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/support/blue-100x100.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/support/Blob.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/support/upload.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/url/url_createobjecturl_blob.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/url/url_createobjecturl_blob-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/url/url_xmlhttprequest.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/imported/wpt/FileAPI/url/url_xmlhttprequest-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/imported/web-platform-tests/FileAPI/blob/Blob-constructor-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -66 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/imported/wpt/FileAPI/blob/Blob-constructor-expected.txt View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/imported/web-platform-tests/FileAPI/blob/Blob-constructor-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -66 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/imported/wpt/FileAPI/blob/Blob-constructor-expected.txt View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 36 (19 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991603002/1
4 years, 7 months ago (2016-05-18 00:46:15 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/223716)
4 years, 7 months ago (2016-05-18 04:57:37 UTC) #7
qyearsley
4 years, 7 months ago (2016-05-18 16:50:14 UTC) #9
Rick Byers
RS LGTM, see https://codereview.chromium.org/1990653002/
4 years, 7 months ago (2016-05-18 16:54:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991603002/1
4 years, 7 months ago (2016-05-18 17:18:31 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/185556)
4 years, 7 months ago (2016-05-18 17:27:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991603002/20001
4 years, 7 months ago (2016-05-18 17:38:28 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/224184)
4 years, 7 months ago (2016-05-18 20:02:54 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991603002/40001
4 years, 7 months ago (2016-05-18 23:36:23 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/224531)
4 years, 7 months ago (2016-05-19 02:15:19 UTC) #24
qyearsley
Note: The specific test which is failing is FileAPI/blob/Blob-constructor.html -- not yet sure why this ...
4 years, 7 months ago (2016-05-19 21:30:35 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991603002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991603002/80001
4 years, 7 months ago (2016-05-19 21:35:05 UTC) #27
jsbell
On 2016/05/19 21:30:35, qyearsley wrote: > Note: The specific test which is failing is FileAPI/blob/Blob-constructor.html ...
4 years, 7 months ago (2016-05-19 22:02:51 UTC) #28
qyearsley
On 2016/05/19 at 22:02:51, jsbell wrote: > On 2016/05/19 21:30:35, qyearsley wrote: > > Note: ...
4 years, 7 months ago (2016-05-19 22:07:45 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991603002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991603002/100001
4 years, 7 months ago (2016-05-19 22:41:57 UTC) #33
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-20 00:29:29 UTC) #34
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 00:30:41 UTC) #36
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/6fa1026b31062bec76795a981bdb04b14328c59f
Cr-Commit-Position: refs/heads/master@{#394925}

Powered by Google App Engine
This is Rietveld 408576698