content/browser/power_save_blocker_factory.cc - Issue 1991593002: Pass SequencedTaskRunner to PowerSaveBlocker for ui/file operations

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/power_save_blocker_factory.cc

Issue 1991593002: Pass SequencedTaskRunner to PowerSaveBlocker for ui/file operations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@device-power-save-blocker

Patch Set: . Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/public/browser/power_save_blocker_factory.h"

	6

	7 #include "content/public/browser/browser_thread.h"

	8

	9 namespace content {

	10

	11 std::unique_ptr<PowerSaveBlocker> CreatePowerSaveBlocker(

	12 PowerSaveBlocker::PowerSaveBlockerType type,

	13 PowerSaveBlocker::Reason reason,

	14 const std::string& description) {

	15 return PowerSaveBlocker::CreateWithTaskRunners(

	16 type, reason, description,

	17 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI),

	18 BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));
	hashimoto 2016/05/24 06:02:42 How about using BrowserThread::GetBlockingPool()-> How about using BrowserThread::GetBlockingPool()->GetSequencedTaskRunner() instead of the FILE thread? The FILE thread was declared dead long ago. https://groups.google.com/a/chromium.org/d/msg/chromium-dev/OaA-9rnjOqI/H0cDC... scottmg 2016/05/24 17:18:03 Done. Show quoted text On 2016/05/24 06:02:42, hashimoto wrote: > How about using BrowserThread::GetBlockingPool()->GetSequencedTaskRunner() > instead of the FILE thread? > > The FILE thread was declared dead long ago. > https://groups.google.com/a/chromium.org/d/msg/chromium-dev/OaA-9rnjOqI/H0cDC... Done.
	19 }

	20

	21 } // namespace content

OLD	NEW

« no previous file with comments | « content/browser/power_save_blocker_chromeos.cc ('k') | content/browser/power_save_blocker_impl.h » ('j') | content/browser/power_save_blocker_impl.h » ('J')