Remove enable_topchrome_md build flag

Remove enable_topchrome_md build flag

Actually use of MD is still controlled by a runtime flag.

Also get rid of Material Design resource build step (on !osx). These drop-in png replacements are no longer used (they've all been converted to vectorized images).

BUG=none

Committed: https://crrev.com/2b0e51237fa07b4fb9f6c20edcefce094f6cf5f5
Cr-Commit-Position: refs/heads/master@{#395146}

[Evan Stade, 2016-05-18 00:07:39]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-18 00:08:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991573002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991573002/1

[commit-bot: I haz the power, 2016-05-18 00:25:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 00:25:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Evan Stade, 2016-05-18 22:01:27]

estade@chromium.org changed reviewers:
+ caitkp@chromium.org, thestig@chromium.org, varkha@chromium.org

[Evan Stade, 2016-05-18 22:01:28]

thestig:
  chrome/installer/linux/common/installer.include
thakis:
  build/*
  chrome/*
  tools/grit/grit_rule.gni
  ui/base/material_design/material_design_controller.cc
  ui/base/material_design/material_design_controller_unittest.cc
caitkp:
  components/*

[Evan Stade, 2016-05-18 22:53:47]

estade@chromium.org changed reviewers:
+ thakis@chromium.org

[Evan Stade, 2016-05-18 22:53:48]

actually +thakis this time. Will look at mac failure.

[Nico, 2016-05-19 00:28:42]

can you elaborate a bit (in the cl description)? It looks like this turns on MD
by default in the code – are all the md resources part of the normal paks now?
Is there a BUG= for turning on MD by default (or an MD launch bug)?

[Evan Stade, 2016-05-19 01:43:36]

Description was changed from

==========
Remove enable_topchrome_md build flag

And get rid of Material Design resource build step (on !osx).

BUG=none
==========

to

==========
Remove enable_topchrome_md build flag

Actually use of MD is still controlled by a runtime flag.

Also get rid of Material Design resource build step (on !osx). These drop-in png
replacements are no longer used (they've all been converted to vectorized
images).

BUG=none
==========

[Evan Stade, 2016-05-19 01:43:48]

On 2016/05/19 00:28:42, Nico (vacation May 19 to 22) wrote:
> can you elaborate a bit (in the cl description)? It looks like this turns on
MD
> by default in the code – are all the md resources part of the normal paks now?
> Is there a BUG= for turning on MD by default (or an MD launch bug)?

updated description --- is that clearer?

[Evan Stade, 2016-05-19 14:09:55]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 14:10:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991573002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991573002/40001

[commit-bot: I haz the power, 2016-05-19 15:15:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 15:15:19]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-05-19 21:38:47]

estade@chromium.org changed reviewers:
+ blundell@chromium.org, scottmg@chromium.org, sky@chromium.org
- caitkp@chromium.org, thakis@chromium.org

[Evan Stade, 2016-05-19 21:38:48]

trying a different set of reviewers...

thestig:
  chrome/*
scottmg:
  build/*
  tools/grit/grit_rule.gni
sky:
  ui/*
blundell:
  components/*

[scottmg, 2016-05-19 21:44:22]

build and tools lgtm

[Lei Zhang, 2016-05-19 21:51:54]

lgtm

https://codereview.chromium.org/1991573002/diff/40001/chrome/chrome_resources...
File chrome/chrome_resources.gyp (right):

https://codereview.chromium.org/1991573002/diff/40001/chrome/chrome_resources...
chrome/chrome_resources.gyp:546: 'conditions': [
Delete?

[Evan Stade, 2016-05-19 22:02:31]

https://codereview.chromium.org/1991573002/diff/40001/chrome/chrome_resources...
File chrome/chrome_resources.gyp (right):

https://codereview.chromium.org/1991573002/diff/40001/chrome/chrome_resources...
chrome/chrome_resources.gyp:546: 'conditions': [
On 2016/05/19 21:51:53, Lei Zhang wrote:
> Delete?

Done.

[Evan Stade, 2016-05-19 22:11:03]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 22:11:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991573002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991573002/60001

[commit-bot: I haz the power, 2016-05-19 22:17:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 22:17:30]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[varkha, 2016-05-19 22:39:31]

Code in ui/base/material_design/ lgtm. I am not familiar enough with the rest
but it seems to lg.

[sky, 2016-05-19 23:11:58]

https://codereview.chromium.org/1991573002/diff/60001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/1991573002/diff/60001/chrome/BUILD.gn#newcode633
chrome/BUILD.gn:633: if (is_mac) {
I was confused by these checks, until I understood your comment about them being
mac only. Could 'chrome_material' be better named? Perhaps chrome_material_mac
given they are mac only now? Same comment for target names and theme_resources.

[Evan Stade, 2016-05-19 23:20:10]

https://codereview.chromium.org/1991573002/diff/60001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/1991573002/diff/60001/chrome/BUILD.gn#newcode633
chrome/BUILD.gn:633: if (is_mac) {
On 2016/05/19 23:11:58, sky wrote:
> I was confused by these checks, until I understood your comment about them
being
> mac only. Could 'chrome_material' be better named? Perhaps chrome_material_mac
> given they are mac only now? Same comment for target names and
theme_resources.

They're going away even on mac, so is_mac is temporary. Would a comment here or
somewhere be helpful iyo?

[blundell, 2016-05-20 08:15:41]

//components lgtm

[sky, 2016-05-20 16:27:54]

LGTM

https://codereview.chromium.org/1991573002/diff/60001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/1991573002/diff/60001/chrome/BUILD.gn#newcode633
chrome/BUILD.gn:633: if (is_mac) {
On 2016/05/19 23:20:10, Evan Stade wrote:
> On 2016/05/19 23:11:58, sky wrote:
> > I was confused by these checks, until I understood your comment about them
> being
> > mac only. Could 'chrome_material' be better named? Perhaps
chrome_material_mac
> > given they are mac only now? Same comment for target names and
> theme_resources.
> 
> They're going away even on mac, so is_mac is temporary. Would a comment here
or
> somewhere be helpful iyo?

I // TODO(estade): temporary, will remove soon, see http://XXXX
would be helpful

[Evan Stade, 2016-05-20 16:54:51]

https://codereview.chromium.org/1991573002/diff/60001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/1991573002/diff/60001/chrome/BUILD.gn#newcode633
chrome/BUILD.gn:633: if (is_mac) {
On 2016/05/20 16:27:54, sky wrote:
> On 2016/05/19 23:20:10, Evan Stade wrote:
> > On 2016/05/19 23:11:58, sky wrote:
> > > I was confused by these checks, until I understood your comment about them
> > being
> > > mac only. Could 'chrome_material' be better named? Perhaps
> chrome_material_mac
> > > given they are mac only now? Same comment for target names and
> > theme_resources.
> > 
> > They're going away even on mac, so is_mac is temporary. Would a comment here
> or
> > somewhere be helpful iyo?
> 
> I // TODO(estade): temporary, will remove soon, see http://XXXX
> would be helpful

Done.

[Evan Stade, 2016-05-20 16:58:08]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-05-20 16:58:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, scottmg@chromium.org, varkha@chromium.org,
sky@chromium.org, blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/1991573002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-20 16:58:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991573002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991573002/80001

[commit-bot: I haz the power, 2016-05-20 20:03:20]

Description was changed from

==========
Remove enable_topchrome_md build flag

Actually use of MD is still controlled by a runtime flag.

Also get rid of Material Design resource build step (on !osx). These drop-in png
replacements are no longer used (they've all been converted to vectorized
images).

BUG=none
==========

to

==========
Remove enable_topchrome_md build flag

Actually use of MD is still controlled by a runtime flag.

Also get rid of Material Design resource build step (on !osx). These drop-in png
replacements are no longer used (they've all been converted to vectorized
images).

BUG=none
==========

[commit-bot: I haz the power, 2016-05-20 20:03:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-20 20:05:31]

Description was changed from

==========
Remove enable_topchrome_md build flag

Actually use of MD is still controlled by a runtime flag.

Also get rid of Material Design resource build step (on !osx). These drop-in png
replacements are no longer used (they've all been converted to vectorized
images).

BUG=none
==========

to

==========
Remove enable_topchrome_md build flag

Actually use of MD is still controlled by a runtime flag.

Also get rid of Material Design resource build step (on !osx). These drop-in png
replacements are no longer used (they've all been converted to vectorized
images).

BUG=none

Committed: https://crrev.com/2b0e51237fa07b4fb9f6c20edcefce094f6cf5f5
Cr-Commit-Position: refs/heads/master@{#395146}
==========

[commit-bot: I haz the power, 2016-05-20 20:05:33]

Patchset 5 (id:??) landed as
https://crrev.com/2b0e51237fa07b4fb9f6c20edcefce094f6cf5f5
Cr-Commit-Position: refs/heads/master@{#395146}

[kolos1, 2016-05-23 11:00:32]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2001093002/ by kolos@chromium.org.

The reason for reverting is: Linux builder failing (isolated tests). 
https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg...

https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg...

Tests failed because of missing chrome_material_100_percent.pak. .