Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1991563003: Inflate rect instead of m_dirtyRect in HTMLCanvasElement::didDraw (Closed)

Created:
4 years, 7 months ago by xidachen
Modified:
4 years, 7 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inflate rect instead of m_dirtyRect in HTMLCanvasElement::didDraw This is a clean up CL for https://codereview.chromium.org/1994613002/, we should not inflate m_dirtyRect because it will accumulate that inflation. BUG=609820 Committed: https://crrev.com/c3d88062790e63b468cbe1b0a672d244baa33f48 Cr-Commit-Position: refs/heads/master@{#394545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xidachen
PTAL
4 years, 7 months ago (2016-05-18 19:52:27 UTC) #2
Justin Novosad
Yes, that's better. lgtm
4 years, 7 months ago (2016-05-18 19:53:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991563003/1
4 years, 7 months ago (2016-05-18 19:55:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 21:07:05 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 21:09:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3d88062790e63b468cbe1b0a672d244baa33f48
Cr-Commit-Position: refs/heads/master@{#394545}

Powered by Google App Engine
This is Rietveld 408576698