Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1991553002: Creates mus implementation of WmShelf (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Creates mus implementation of WmShelf At this point it's just a stub. BUG=603369 TEST=none R=msw@chromium.org Committed: https://crrev.com/88028961efbe33410aa37e21160bf2bdbcec0a8b Cr-Commit-Position: refs/heads/master@{#394497}

Patch Set 1 #

Total comments: 7

Patch Set 2 : merge #

Patch Set 3 : private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -10 lines) Patch
M mash/wm/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A mash/wm/bridge/wm_shelf_mus.h View 1 2 1 chunk +50 lines, -0 lines 0 comments Download
A mash/wm/bridge/wm_shelf_mus.cc View 1 chunk +74 lines, -0 lines 0 comments Download
M mash/wm/shelf_layout_manager.h View 1 chunk +12 lines, -4 lines 0 comments Download
M mash/wm/shelf_layout_manager.cc View 4 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sky
In case you haven't seen any of the ash/wm/common code it's the windowmanagement code shared ...
4 years, 7 months ago (2016-05-17 23:51:26 UTC) #1
msw
https://codereview.chromium.org/1991553002/diff/1/mash/wm/bridge/wm_shelf_mus.cc File mash/wm/bridge/wm_shelf_mus.cc (right): https://codereview.chromium.org/1991553002/diff/1/mash/wm/bridge/wm_shelf_mus.cc#newcode13 mash/wm/bridge/wm_shelf_mus.cc:13: #define NOTIMPLEMENTED() DVLOG(1) << "notimplemented" Did you actually mean ...
4 years, 7 months ago (2016-05-18 00:37:31 UTC) #2
sky
https://codereview.chromium.org/1991553002/diff/1/mash/wm/bridge/wm_shelf_mus.cc File mash/wm/bridge/wm_shelf_mus.cc (right): https://codereview.chromium.org/1991553002/diff/1/mash/wm/bridge/wm_shelf_mus.cc#newcode13 mash/wm/bridge/wm_shelf_mus.cc:13: #define NOTIMPLEMENTED() DVLOG(1) << "notimplemented" On 2016/05/18 00:37:30, msw ...
4 years, 7 months ago (2016-05-18 16:18:32 UTC) #3
msw
lgtm https://codereview.chromium.org/1991553002/diff/1/mash/wm/bridge/wm_shelf_mus.h File mash/wm/bridge/wm_shelf_mus.h (right): https://codereview.chromium.org/1991553002/diff/1/mash/wm/bridge/wm_shelf_mus.h#newcode27 mash/wm/bridge/wm_shelf_mus.h:27: // ash::wm::WmShelf: On 2016/05/18 16:18:32, sky wrote: > ...
4 years, 7 months ago (2016-05-18 17:25:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991553002/40001
4 years, 7 months ago (2016-05-18 18:30:06 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-18 19:17:28 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 19:18:37 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/88028961efbe33410aa37e21160bf2bdbcec0a8b
Cr-Commit-Position: refs/heads/master@{#394497}

Powered by Google App Engine
This is Rietveld 408576698