Update status for

Update status for

  ./tools/test.py -mall
  ./tools/test.py -mdebug,release --checked
  ./tools/test.py -mrelease,product -cdart2app -rdart_product
  ./tools/test.py -mrelease --checked -cdart2app -rdart_product

Missing
  ./tools/test.py -mdebug -cdart2app -rdart_product
  ./tools/test.py -mdebug --checked -cdart2app -rdart_product

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/7d3cd143f73ce30e45c2353b00acb0a80261ff13

[rmacnak, 2016-05-17 23:54:47]

Description was changed from

==========
Green
./tools/test.py -mall
./tools/test.py -mdebug,release --checked
./tools/test.py -mall -cdart2app -rdart_product
./tools/test.py -mdebug,release --checked -cdart2app -rdart_product
==========

to

==========
Update status for

  ./tools/test.py -mall
  ./tools/test.py -mdebug,release --checked
  ./tools/test.py -mrelease,product -cdart2app -rdart_product
  ./tools/test.py -mrelease --checked -cdart2app -rdart_product

Missing
  ./tools/test.py -mdebug -cdart2app -rdart_product
  ./tools/test.py -mdebug --checked -cdart2app -rdart_product
==========

[rmacnak, 2016-05-18 00:42:31]

Description was changed from

==========
Update status for

  ./tools/test.py -mall
  ./tools/test.py -mdebug,release --checked
  ./tools/test.py -mrelease,product -cdart2app -rdart_product
  ./tools/test.py -mrelease --checked -cdart2app -rdart_product

Missing
  ./tools/test.py -mdebug -cdart2app -rdart_product
  ./tools/test.py -mdebug --checked -cdart2app -rdart_product
==========

to

==========
Update status for

  ./tools/test.py -mall
  ./tools/test.py -mdebug,release --checked
  ./tools/test.py -mrelease,product -cdart2app -rdart_product
  ./tools/test.py -mrelease --checked -cdart2app -rdart_product

Missing
  ./tools/test.py -mdebug -cdart2app -rdart_product
  ./tools/test.py -mdebug --checked -cdart2app -rdart_product
==========

[rmacnak, 2016-05-18 00:49:16]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-05-18 18:10:56]

lgtm

https://codereview.chromium.org/1991543002/diff/40001/runtime/tests/vm/vm.status
File runtime/tests/vm/vm.status (right):

https://codereview.chromium.org/1991543002/diff/40001/runtime/tests/vm/vm.sta...
runtime/tests/vm/vm.status:110: cc/GetFunctionNames: Fail,OK
Are these Ok for the same reason (Expects exact type name?), could you add that
as a comment.

https://codereview.chromium.org/1991543002/diff/40001/tests/standalone/standa...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/1991543002/diff/40001/tests/standalone/standa...
tests/standalone/standalone.status:261: [ $runtime == dart_precompiled ||
$runtime == dart_product || $mode == product ]
mode == product would cover runtime == dart_product too right

[rmacnak, 2016-05-18 19:26:36]

https://codereview.chromium.org/1991543002/diff/40001/runtime/tests/vm/vm.status
File runtime/tests/vm/vm.status (right):

https://codereview.chromium.org/1991543002/diff/40001/runtime/tests/vm/vm.sta...
runtime/tests/vm/vm.status:110: cc/GetFunctionNames: Fail,OK
On 2016/05/18 18:10:56, siva wrote:
> Are these Ok for the same reason (Expects exact type name?), could you add
that
> as a comment.

Yes, added comment.

https://codereview.chromium.org/1991543002/diff/40001/tests/standalone/standa...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/1991543002/diff/40001/tests/standalone/standa...
tests/standalone/standalone.status:261: [ $runtime == dart_precompiled ||
$runtime == dart_product || $mode == product ]
On 2016/05/18 18:10:56, siva wrote:
> mode == product would cover runtime == dart_product too right

Not always. For example,

test.py -mdebug,release -cdart2app -rdart_product

(I.e., an app snapshot running in debug or release mode)

[rmacnak, 2016-05-18 19:54:38]

Description was changed from

==========
Update status for

  ./tools/test.py -mall
  ./tools/test.py -mdebug,release --checked
  ./tools/test.py -mrelease,product -cdart2app -rdart_product
  ./tools/test.py -mrelease --checked -cdart2app -rdart_product

Missing
  ./tools/test.py -mdebug -cdart2app -rdart_product
  ./tools/test.py -mdebug --checked -cdart2app -rdart_product
==========

to

==========
Update status for

  ./tools/test.py -mall
  ./tools/test.py -mdebug,release --checked
  ./tools/test.py -mrelease,product -cdart2app -rdart_product
  ./tools/test.py -mrelease --checked -cdart2app -rdart_product

Missing
  ./tools/test.py -mdebug -cdart2app -rdart_product
  ./tools/test.py -mdebug --checked -cdart2app -rdart_product

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7d3cd143f73ce30e45c2353b00acb0a80261ff13
==========

[rmacnak, 2016-05-18 19:54:39]

Committed patchset #4 (id:60001) manually as
7d3cd143f73ce30e45c2353b00acb0a80261ff13 (presubmit successful).