Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: content/browser/database_util_unittest.cc

Issue 199153003: Look closer at the components of vfsfilenames that are used filenames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | webkit/browser/database/database_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/string_piece.h" 5 #include "base/strings/string_piece.h"
6 #include "base/strings/utf_string_conversions.h" 6 #include "base/strings/utf_string_conversions.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 #include "webkit/browser/database/database_util.h" 8 #include "webkit/browser/database/database_util.h"
9 #include "webkit/common/database/database_identifier.h" 9 #include "webkit/common/database/database_identifier.h"
10 10
(...skipping 26 matching lines...) Expand all
37 static void TestValidOriginIdentifier(bool expected_result, 37 static void TestValidOriginIdentifier(bool expected_result,
38 const std::string& id) { 38 const std::string& id) {
39 EXPECT_EQ(expected_result, 39 EXPECT_EQ(expected_result,
40 DatabaseUtil::IsValidOriginIdentifier(id)); 40 DatabaseUtil::IsValidOriginIdentifier(id));
41 } 41 }
42 42
43 namespace content { 43 namespace content {
44 44
45 // Test DatabaseUtil::CrackVfsFilePath on various inputs. 45 // Test DatabaseUtil::CrackVfsFilePath on various inputs.
46 TEST(DatabaseUtilTest, CrackVfsFilePathTest) { 46 TEST(DatabaseUtilTest, CrackVfsFilePathTest) {
47 TestVfsFilePath(true, "origin/#", "origin", "", ""); 47 TestVfsFilePath(true, "http_origin_0/#", "http_origin_0", "", "");
48 TestVfsFilePath(true, "origin/#suffix", "origin", "", "suffix"); 48 TestVfsFilePath(true,
49 TestVfsFilePath(true, "origin/db_name#", "origin", "db_name", ""); 49 "http_origin_0/#suffix", "http_origin_0", "", "suffix");
50 TestVfsFilePath(true, "origin/db_name#suffix", "origin", "db_name", "suffix"); 50 TestVfsFilePath(true,
51 TestVfsFilePath(false, "origindb_name#"); 51 "http_origin_0/db_name#", "http_origin_0", "db_name", "");
52 TestVfsFilePath(false, "origindb_name#suffix"); 52 TestVfsFilePath(true,
53 TestVfsFilePath(false, "origin/db_name"); 53 "http_origin_0/db_name#suffix", "http_origin_0", "db_name", "suffix");
54 TestVfsFilePath(false, "origin#db_name/suffix"); 54 TestVfsFilePath(false, "http_origin_0db_name#");
55 TestVfsFilePath(false, "http_origin_0db_name#suffix");
56 TestVfsFilePath(false, "http_origin_0/db_name");
57 TestVfsFilePath(false, "http_origin_0#db_name/suffix");
55 TestVfsFilePath(false, "/db_name#"); 58 TestVfsFilePath(false, "/db_name#");
56 TestVfsFilePath(false, "/db_name#suffix"); 59 TestVfsFilePath(false, "/db_name#suffix");
57 } 60 }
58 61
59 TEST(DatabaseUtilTest, OriginIdentifiers) { 62 TEST(DatabaseUtilTest, OriginIdentifiers) {
60 const GURL kFileOrigin(GURL("file:///").GetOrigin()); 63 const GURL kFileOrigin(GURL("file:///").GetOrigin());
61 const GURL kHttpOrigin(GURL("http://bar/").GetOrigin()); 64 const GURL kHttpOrigin(GURL("http://bar/").GetOrigin());
62 EXPECT_EQ(kFileOrigin, ToAndFromOriginIdentifier(kFileOrigin)); 65 EXPECT_EQ(kFileOrigin, ToAndFromOriginIdentifier(kFileOrigin));
63 EXPECT_EQ(kHttpOrigin, ToAndFromOriginIdentifier(kHttpOrigin)); 66 EXPECT_EQ(kHttpOrigin, ToAndFromOriginIdentifier(kHttpOrigin));
64 } 67 }
65 68
66 TEST(DatabaseUtilTest, IsValidOriginIdentifier) { 69 TEST(DatabaseUtilTest, IsValidOriginIdentifier) {
67 TestValidOriginIdentifier(true, "http_bar_0"); 70 TestValidOriginIdentifier(true, "http_bar_0");
68 TestValidOriginIdentifier(true, ""); 71 TestValidOriginIdentifier(false, "");
69 TestValidOriginIdentifier(false, "bad..id"); 72 TestValidOriginIdentifier(false, "bad..id");
70 TestValidOriginIdentifier(false, "bad/id"); 73 TestValidOriginIdentifier(false, "bad/id");
71 TestValidOriginIdentifier(false, "bad\\id"); 74 TestValidOriginIdentifier(false, "bad\\id");
75 TestValidOriginIdentifier(false, "http_bad:0_2");
72 TestValidOriginIdentifier(false, std::string("bad\0id", 6)); 76 TestValidOriginIdentifier(false, std::string("bad\0id", 6));
73 } 77 }
74 78
75 } // namespace content 79 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | webkit/browser/database/database_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698