Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp

Issue 1991513003: Lock animated property type of result animation during processing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lock-animated-property-in
Patch Set: Update comment and mention bug. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp b/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
index 6429c840440def0edeac06af55d24b1fc7145d30..fe2e6c2ddaee9d34ff2f5c32d8a55dfcfa1905f2 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
@@ -286,6 +286,11 @@ void SVGAnimateElement::clearAnimatedType()
if (!m_animatedProperty)
return;
+ // The animated property lock is held for the "result animation" (see SMILTimeContainer::updateAnimations())
+ // while we're processing an animation group. We will very likely crash later if we clear the animated type
+ // while the lock is held. See crbug.com/581546.
+ RELEASE_ASSERT(!animatedTypeIsLocked());
+
SVGElement* targetElement = this->targetElement();
if (!targetElement) {
m_animatedProperty.clear();
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698