Lock animated property type of result animation during processing

third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h

 /*
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 92 matching lines @@
     static SMILTime parseOffsetValue(const String&);
 
     bool isContributing(SMILTime elapsed) const;
     bool isFrozen() const;
 
     unsigned documentOrderIndex() const { return m_documentOrderIndex; }
     void setDocumentOrderIndex(unsigned index) { m_documentOrderIndex = index; }
 
     virtual void resetAnimatedType() = 0;
     virtual void clearAnimatedType() = 0;
+    virtual void lockAnimatedType() = 0;

[fs, 2016/05/18 16:10:40]

Any particular reason we want these to be virtual? I.e why not just put the flag
in SVGSMILElement and add a method to query it in SVGAnimateElement? (Would make
for a slightly smaller patch, but slightly larger elements granted.)

[davve, 2016/05/19 06:38:49]

It was an attempt at limiting intrusiveness and keeping the lock close to the
actual m_animatedProperty member. But the simplicity of your proposal convinces
me. Patch updated.

+    virtual void unlockAnimatedType() = 0;
     virtual void applyResultsToTarget() = 0;
 
     void connectSyncBaseConditions();
     void connectEventBaseConditions();
 
     void dispatchPendingEvent(SMILEventSender*);
     void dispatchRepeatEvents(unsigned);
 
     virtual bool isSVGDiscardElement() const { return false; }
 
@@ skipping 161 matching lines @@
 {
     return element.hasTagName(SVGNames::setTag) || element.hasTagName(SVGNames::animateTag) || element.hasTagName(SVGNames::animateMotionTag)
         || element.hasTagName(SVGNames::animateTransformTag) || element.hasTagName((SVGNames::discardTag));
 }
 
 DEFINE_SVGELEMENT_TYPE_CASTS_WITH_FUNCTION(SVGSMILElement);
 
 } // namespace blink
 
 #endif // SVGSMILElement_h