components/history/core/browser/top_sites_database.cc - Issue 1991503002: [sql] sql::ScopedErrorIgnorer rename to sql::test::ScopedErrorExpecter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/top_sites_database.cc

Issue 1991503002: [sql] sql::ScopedErrorIgnorer rename to sql::test::ScopedErrorExpecter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/history/core/browser/thumbnail_database_unittest.cc ('k') | components/history/core/browser/top_sites_database_unittest.cc » ('j') | sql/connection.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/top_sites_database.cc

diff --git a/components/history/core/browser/top_sites_database.cc b/components/history/core/browser/top_sites_database.cc

index 44ad7600b6aa6fc6397418023bc74c881d566b8a..09efcf70ccc3a33b4c0f034a8a856c2eca20604b 100644

--- a/components/history/core/browser/top_sites_database.cc

+++ b/components/history/core/browser/top_sites_database.cc

@@ -345,7 +345,7 @@ void DatabaseErrorCallback(sql::Connection* db,

// are seen.

// The default handling is to assert on debug and to ignore on release.

- if (!sql::Connection::ShouldIgnoreSqliteError(extended_error))

+ if (!sql::Connection::IsExpectedSqliteError(extended_error))

DLOG(FATAL) << db->GetErrorMessage();

}