content/browser/appcache/appcache_database.cc - Issue 1991503002: [sql] sql::ScopedErrorIgnorer rename to sql::test::ScopedErrorExpecter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_database.cc

Issue 1991503002: [sql] sql::ScopedErrorIgnorer rename to sql::test::ScopedErrorExpecter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restore file rename Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/affiliation_database_unittest.cc ('k') | content/browser/appcache/appcache_database_unittest.cc » ('j') | sql/connection.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_database.cc

diff --git a/content/browser/appcache/appcache_database.cc b/content/browser/appcache/appcache_database.cc

index 690da3546235e2178be88c632556f24db6601fa0..d80c5536a142993810848a8ca0ea727f3a4680f8 100644

--- a/content/browser/appcache/appcache_database.cc

+++ b/content/browser/appcache/appcache_database.cc

@@ -1321,7 +1321,7 @@ bool AppCacheDatabase::DeleteExistingAndCreateNewDatabase() {

void AppCacheDatabase::OnDatabaseError(int err, sql::Statement* stmt) {

was_corruption_detected_ |= sql::IsErrorCatastrophic(err);

- if (!db_->ShouldIgnoreSqliteError(err))

+ if (!db_->IsExpectedSqliteError(err))

DLOG(ERROR) << db_->GetErrorMessage();

// TODO: Maybe use non-catostrophic errors to trigger a full integrity check?

}