mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl - Issue 1991463002: Mojo: Expose untyped associated endpoints through public API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl

Issue 1991463002: Mojo: Expose untyped associated endpoints through public API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/multiplex_router_unittest.cc ('k') | mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl

index c0835a7bc2cd7148b4dfa1b20a08ddec5985cc00..4fc70d414f7059529ed9fd271a28bcd652286a10 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl

@@ -89,10 +89,8 @@ bool {{struct.name}}DataView::Read{{name|under_to_camel}}(

if (data_->header_.version < {{pf.min_version}})

return result;

{%- endif %}

- mojo::internal::AssociatedInterfaceRequestHelper::SetHandle(

- &result,

- context_->router->CreateLocalEndpointHandle(

- mojo::internal::FetchAndReset(&data_->{{name}})));

+ result.Bind(context_->router->CreateLocalEndpointHandle(

+ mojo::internal::FetchAndReset(&data_->{{name}})));

return result;

}