Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1991453002:
[Cronet] add a test assertion in UploadDataProvidersTest.java (Closed)
Description[Cronet] add a test assertion in UploadDataProvidersTest.java
This CL adds a test assertion in UploadDataProvidersTest.java to make sure
getLength() is correct when UploadDataProvider is constructed with a byte array
with an offset.
BUG=603124
Committed: https://crrev.com/e18f28140777747260eabb021831c59ee03bc319
Cr-Commit-Position: refs/heads/master@{#394392}
Patch Set 1 : #
Messages
Total messages: 20 (11 generated)
Patchset #1 (id:1) has been deleted
xunjieli@chromium.org changed reviewers: + rohitagr@google.com
Rohit, I am not sure if this is what you meant. PTAL.
On 2016/05/17 20:27:53, xunjieli wrote: > Rohit, I am not sure if this is what you meant. PTAL. Perfect, thanks a lot. LGTM.
xunjieli@chromium.org changed reviewers: + mgersh@chromium.org
Thanks, Rohit! Miriam, PTAL.
The CQ bit was checked by rohitagr@google.com
The CQ bit was unchecked by rohitagr@google.com
The CQ bit was checked by rohitagr@google.com
The CQ bit was unchecked by rohitagr@google.com
The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991453002/20001
On 2016/05/17 21:05:26, xunjieli wrote: > Thanks, Rohit! > > Miriam, PTAL. lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xunjieli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991453002/20001
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Cronet] add a test assertion in UploadDataProvidersTest.java This CL adds a test assertion in UploadDataProvidersTest.java to make sure getLength() is correct when UploadDataProvider is constructed with a byte array with an offset. BUG=603124 ========== to ========== [Cronet] add a test assertion in UploadDataProvidersTest.java This CL adds a test assertion in UploadDataProvidersTest.java to make sure getLength() is correct when UploadDataProvider is constructed with a byte array with an offset. BUG=603124 Committed: https://crrev.com/e18f28140777747260eabb021831c59ee03bc319 Cr-Commit-Position: refs/heads/master@{#394392} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e18f28140777747260eabb021831c59ee03bc319 Cr-Commit-Position: refs/heads/master@{#394392} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
