🏦 Clean up unnecessary parameters.

Clean up unnecessary parameters.

- Rename methods to be more accurate to what is intended.
- Fetch the old file store folder only when necessary, after we know
  that a migration is in order.

BUG=612574
Committed: https://crrev.com/6361f63e12712a9b4e40f5b0b1aab31a0bae9bb4
Cr-Commit-Position: refs/heads/master@{#394402}

[Peter Wen, 2016-05-17 20:12:19]

wnwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Peter Wen, 2016-05-17 20:12:20]

Leaving to next CL: Using SharedPreferences to make the file migration task
obsolete.

I'll then introduce a separate task to pre-warm the state directory fetch,
similar to the existing one in StorageDelegate, maybe pull that up to
TabPersister as I found it really hard to remove StorageDelegate. This is
necessary since the file migration task used to be the first
caller/background-warmer-upper.

The other option is to do the same pull-up to TabPersister, just have the
migration check be tacked onto the end of that AsyncTask, since it's just one
extra listFiles call for all intents and purposes.

WDYT? ⛽

[gone, 2016-05-17 20:35:38]

This patch lgtm, but tests are failing.

First plan sounds fine, I think.  Hard for me to visualize it without code.

TabPersister only really needed to exist because StorageDelegate was doing
practically everything differently from the TabPersistentStore.  I'd just leave
everything in TabPersistentStore until we really have to move it upward.

https://codereview.chromium.org/1991443002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
(right):

https://codereview.chromium.org/1991443002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java:973:
// Explicitly serializing file mutations (save & delete) to ensure they occur in
order.
Maybe make this a function comment?  It's weird to just have it dangling here.

"File mutations (e.g. saving & deleting) are explicitly serialized to ensure
that they occur in the correct order."

[Peter Wen, 2016-05-17 21:09:09]

Okay, sounds good. Won't move up to TabPersister then. For some reason my
changes in RestoreMigrateTest.java were lost, fixed now.

https://codereview.chromium.org/1991443002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
(right):

https://codereview.chromium.org/1991443002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java:973:
// Explicitly serializing file mutations (save & delete) to ensure they occur in
order.
On 2016/05/17 20:35:37, dfalcantara wrote:
> Maybe make this a function comment?  It's weird to just have it dangling here.
> 
> "File mutations (e.g. saving & deleting) are explicitly serialized to ensure
> that they occur in the correct order."

Done.

[Peter Wen, 2016-05-17 21:09:15]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2016-05-17 21:09:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1991443002/#ps20001
(title: "Fix tests and comment.")

[commit-bot: I haz the power, 2016-05-17 21:09:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991443002/20001

[commit-bot: I haz the power, 2016-05-17 22:05:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 22:05:10]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Peter Wen, 2016-05-18 12:42:00]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2016-05-18 12:42:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1991443002/#ps40001
(title: "Fix findbugs.")

[commit-bot: I haz the power, 2016-05-18 12:42:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991443002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991443002/40001

[commit-bot: I haz the power, 2016-05-18 13:28:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-18 13:30:19]

Description was changed from

==========
Clean up unnecessary parameters.

- Rename methods to be more accurate to what is intended.
- Fetch the old file store folder only when necessary, after we know
  that a migration is in order.

BUG=612574
==========

to

==========
Clean up unnecessary parameters.

- Rename methods to be more accurate to what is intended.
- Fetch the old file store folder only when necessary, after we know
  that a migration is in order.

BUG=612574

Committed: https://crrev.com/6361f63e12712a9b4e40f5b0b1aab31a0bae9bb4
Cr-Commit-Position: refs/heads/master@{#394402}
==========

[commit-bot: I haz the power, 2016-05-18 13:30:20]

Patchset 3 (id:??) landed as
https://crrev.com/6361f63e12712a9b4e40f5b0b1aab31a0bae9bb4
Cr-Commit-Position: refs/heads/master@{#394402}