Issue 19914002: Use toSVGPathElement() instead of static_cast<>

Issue 19914002: Use toSVGPathElement() instead of static_cast<> (Closed)

Created:
7 years, 5 months ago by gyuyoung-inactive

Modified:
7 years, 4 months ago

Reviewers:
tkent

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Use toSVGPathElement() instead of static_cast<> Though there is toSVGPathElement(), some files still use static_cast<SVGPathElement*>. To remove all static_cast<> use, we need to change argument from SVGElement to Element. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154621

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -11 lines)			Patch
M	Source/core/rendering/svg/RenderSVGTextPath.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/svg/SVGPathData.cpp	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/rendering/svg/SVGRenderTreeAsText.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGMPathElement.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGPathElement.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGPathSegList.cpp	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/svg/properties/SVGAnimatedPathSegListPropertyTearOff.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/properties/SVGPathSegListPropertyTearOff.cpp	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

gyuyoung-inactive

Add tkent as reviewer. I checked if there is problem on debug build locally ;)

7 years, 5 months ago (2013-07-21 12:00:52 UTC) #1

tkent

https://codereview.chromium.org/19914002/diff/1/Source/core/rendering/svg/SVGPathData.cpp File Source/core/rendering/svg/SVGPathData.cpp (right): https://codereview.chromium.org/19914002/diff/1/Source/core/rendering/svg/SVGPathData.cpp#newcode75 Source/core/rendering/svg/SVGPathData.cpp:75: ASSERT(element->hasTagName(SVGNames::pathTag)); This ASSERT is redundant. Please remove it. https://codereview.chromium.org/19914002/diff/1/Source/core/svg/SVGPathSegList.cpp ...

7 years, 5 months ago (2013-07-21 20:50:30 UTC) #2

gyuyoung-inactive

On 2013/07/21 20:50:30, tkent wrote: > https://codereview.chromium.org/19914002/diff/1/Source/core/rendering/svg/SVGPathData.cpp > File Source/core/rendering/svg/SVGPathData.cpp (right): > > https://codereview.chromium.org/19914002/diff/1/Source/core/rendering/svg/SVGPathData.cpp#newcode75 > ...

7 years, 5 months ago (2013-07-22 00:47:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19914002/6001

7 years, 5 months ago (2013-07-22 00:50:08 UTC) #5

Message was sent while issue was closed.

Change committed as 154621

Expand Messages | Collapse Messages