Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1991363003: cc: Plumb gpu/sw image decode limits as layer tree settings. (Closed)

Created:
4 years, 7 months ago by vmpstr
Modified:
4 years, 7 months ago
Reviewers:
enne (OOO), ericrk
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Plumb gpu/sw image decode limits as layer tree settings. This patch allows us to vary the memory limits used in image decodes by plumbing it as layer tree settings. R=enne, ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e0b9936e67197c642cf2eb165b09808779067b96 Cr-Commit-Position: refs/heads/master@{#395167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -88 lines) Patch
M cc/playback/raster_source_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/test/fake_tile_manager.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M cc/tiles/gpu_image_decode_controller.h View 2 chunks +3 lines, -1 line 0 comments Download
M cc/tiles/gpu_image_decode_controller.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M cc/tiles/gpu_image_decode_controller_unittest.cc View 19 chunks +27 lines, -36 lines 0 comments Download
M cc/tiles/software_image_decode_controller.h View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/tiles/software_image_decode_controller.cc View 4 chunks +4 lines, -11 lines 0 comments Download
M cc/tiles/software_image_decode_controller_unittest.cc View 29 chunks +37 lines, -28 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
vmpstr
Please take a look.
4 years, 7 months ago (2016-05-19 23:15:37 UTC) #2
ericrk
lgtm
4 years, 7 months ago (2016-05-19 23:32:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991363003/1
4 years, 7 months ago (2016-05-19 23:52:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/217043)
4 years, 7 months ago (2016-05-20 03:13:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991363003/1
4 years, 7 months ago (2016-05-20 20:09:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 21:15:33 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 21:17:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0b9936e67197c642cf2eb165b09808779067b96
Cr-Commit-Position: refs/heads/master@{#395167}

Powered by Google App Engine
This is Rietveld 408576698