Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1991353002: Don't restart the GPU process when switching to another TTY (Closed)

Created:
4 years, 7 months ago by Tom (Use chromium acct)
Modified:
4 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't exit the GPU process if on a non-host TTY Requests to the X11 server may be stalled if we switch away from the TTY that is hosting the X server. In this case, don't restart the GPU process as it will become responsive again when we switch to its TTY. BUG=355720 Committed: https://crrev.com/9db5a0e3f53edfa3cc653d9d6f8476c17bc7d2b9 Cr-Commit-Position: refs/heads/master@{#394957}

Patch Set 1 #

Patch Set 2 : Don't exit the GPU process if on a non-host TTY #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
M content/gpu/gpu_watchdog_thread.h View 2 chunks +6 lines, -4 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.cc View 7 chunks +24 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Tom (Use chromium acct)
4 years, 7 months ago (2016-05-19 21:39:16 UTC) #2
piman
lgtm
4 years, 7 months ago (2016-05-19 21:43:38 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991353002/20001
4 years, 7 months ago (2016-05-19 21:45:11 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/232457)
4 years, 7 months ago (2016-05-19 23:44:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991353002/20001
4 years, 7 months ago (2016-05-20 01:37:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 01:57:27 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 01:58:42 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9db5a0e3f53edfa3cc653d9d6f8476c17bc7d2b9
Cr-Commit-Position: refs/heads/master@{#394957}

Powered by Google App Engine
This is Rietveld 408576698