Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 1991293002: [api] Remove deprectated memory allocation callback api (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 6 months ago
CC:
Hannes Payer (out of office), Paweł Hajdan Jr., ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Remove deprectated memory allocation callback API Users of this api should use a combination of |RequestInterrupt| and |GCCallback| (see |AddGCPrologueCallback| and friends) to keep track allocated memory. BUG=v8:4813 LOG=Y R=jochen@chromium.org Committed: https://crrev.com/07fadde87c0de118daf80e42c9ae64e8a611e1f6 Cr-Commit-Position: refs/heads/master@{#36594}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -118 lines) Patch
M include/v8.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/heap/spaces.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/heap/spaces.cc View 1 4 chunks +0 lines, -59 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Michael Lippautz
ptal; we've had a branch cut inbetween, so we can remove it?
4 years, 7 months ago (2016-05-25 13:43:29 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991293002/40001
4 years, 6 months ago (2016-05-30 13:55:09 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-30 14:24:15 UTC) #11
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-05-30 14:27:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991293002/40001
4 years, 6 months ago (2016-05-30 15:49:28 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-05-30 15:51:31 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 15:54:16 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/07fadde87c0de118daf80e42c9ae64e8a611e1f6
Cr-Commit-Position: refs/heads/master@{#36594}

Powered by Google App Engine
This is Rietveld 408576698